Consider lowering overall sampling frequencies#409
Draft
Conversation
CI Test ResultsRun: #22726782213 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-03-05 16:24:23 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider lowering overall sampling frequencies
Problem Description
We can get away with much longer sampling interval for wallclock, reducing overhead and possibility for clash with the cpu profiler.
Wallclock profile should be fine with the sampling interval in order of 100s of ms
Implement the accompanying regression test:
The number of samples collected during a test must correspond to the expected number of samples, based on frequency and the max number of threads we sample on a tick
Limitations
The wallclock sampling frequency must be consistent across all wallclock engines (ASGCT, J9, JVMTI)
Acceptance Rules
Auto-generated by ouroboros. Adversarial review: PASS.