Skip to content

Ensure no warnings on various targets#7245

Draft
ShaharNaveh wants to merge 12 commits intoRustPython:mainfrom
ShaharNaveh:disallow-warnings
Draft

Ensure no warnings on various targets#7245
ShaharNaveh wants to merge 12 commits intoRustPython:mainfrom
ShaharNaveh:disallow-warnings

Conversation

@ShaharNaveh
Copy link
Contributor

ATM build on android yield an "unused import" warning. This PR aims to make sure warnings like this don't appear from time to time

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Code has been automatically formatted

The code in this PR has been formatted using:

  • ruff format
    Please pull the latest changes before pushing again:
git pull origin disallow-warnings

#[pyarg(positional, default)]
#[pystruct_sequence(unnamed)]
pub st_mtime_int: libc::time_t,
#[cfg_attr(target_env = "musl", allow(deprecated))]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No matter what I do, the deprecation warning still shows. @youknowone I believe we have a bug related to #[cfg_attr(...)] with #[pystruct_sequence(...)] (and possibly related to when used with #[pyarg(...)])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants