Draft
Conversation
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This was referenced Jan 15, 2025
Merged
This was referenced Jan 15, 2025
Merged
Parent: #4378 Command has been implemented, plus a few minor tweaks here and there.
Parent: #4378 Implemented along with examples/tests, including some unblocked by this.
Deploying with
|
| Status | Latest Commit | Updated (UTC) |
|---|---|---|
| ❌ Deployment failed | b4e8283 | May 18 2025, 10:56 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is the target of Ariakit Solid-related PRs for the time being. Do not merge into main for now!
Changes:
Primitives:
Quick & dirty TODOs:
-gin dependents count script[event-chain]- array overload thingy[capture-events]- solid doesn't delegate capture events and there is no direct prop for capture events to chain with, tricky stuff[style-chain]- styles can be string, maybe grab function from solid-primitives (the one used within combineProps)[tab-index]- solid supports string also while react apparently normalizes to number?<As />component is executed directly inrenderprop, if even possible (e.g.render={<Whatever />}tscerrors :(Additional grep codes:
[ariakit-ask]- things to ask or figure out about ariakit internals and logic