-
Notifications
You must be signed in to change notification settings - Fork 1.1k
BigQuery timestamp parsing regression (are restrictive timestamp parsing changes intentional?) #4500
Copy link
Copy link
Closed
Labels
🚨 criticalP0 critical issue. Requires immediate fixP0 critical issue. Requires immediate fixapi: bigqueryIssues related to the BigQuery API.Issues related to the BigQuery API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Metadata
Metadata
Assignees
Labels
🚨 criticalP0 critical issue. Requires immediate fixP0 critical issue. Requires immediate fixapi: bigqueryIssues related to the BigQuery API.Issues related to the BigQuery API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Environment details
Overview of issue
In commit fc8438b the BigQuery date parsing format string was changed from
yyyy-MM-dd HH:mm:ss.SSSSSSZZtoyyyy-MM-dd HH:mm:ss.SSSSSSxxxThis has broken backwards compatibility in two ways.
Zor+0000for the timezone component.Was this change desirable? I don't understand why you would intentionally make the timestamp parsing as restrictive as this.
In the code sample below, all the example date strings will parse fine in the older BigQuery SDK versions, but fail in the current version.
Code sample
(code is in Scala but that isn't relevant to the issue)