Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

feat: implement confirmation threshold for semantic operators#1251

Merged
sycai merged 16 commits into
mainfrom
b386261373
Jan 3, 2025
Merged

feat: implement confirmation threshold for semantic operators#1251
sycai merged 16 commits into
mainfrom
b386261373

Conversation

@sycai

@sycai sycai commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

If the amount of row to be processed exceeds this threshold, we will ask for keyboard input from user to confirm.

@sycai sycai requested review from a team and jialuoo January 3, 2025 01:33
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label Bot added the size: l Pull request size is large. label Jan 3, 2025
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jan 3, 2025
@sycai sycai requested a review from tswast January 3, 2025 01:36
Comment thread bigframes/_config/compute_options.py Outdated
Comment thread bigframes/operations/semantics.py Outdated
Comment thread bigframes/operations/semantics.py Outdated
Comment thread bigframes/operations/semantics.py Outdated
Comment thread bigframes/operations/semantics.py Outdated
Comment thread bigframes/_config/compute_options.py Outdated
@sycai sycai requested a review from tswast January 3, 2025 19:04
Comment thread tests/system/large/operations/test_semantics.py Outdated
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 3, 2025
@sycai sycai requested a review from tswast January 3, 2025 21:50
@sycai sycai enabled auto-merge (squash) January 3, 2025 23:17
@sycai sycai merged commit 5ba4511 into main Jan 3, 2025
@sycai sycai deleted the b386261373 branch January 3, 2025 23:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants