Skip to content

Commit c1adb46

Browse files
ajaysubraclaude
andcommitted
refactor: Remove isFormLifecycleCallbackRegistered property
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent db7adf5 commit c1adb46

File tree

2 files changed

+1
-20
lines changed

2 files changed

+1
-20
lines changed

sdk/forms/src/main/java/com/klaviyo/forms/InAppForms.kt

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -111,15 +111,6 @@ fun Klaviyo.unregisterFormLifecycleCallback(): Klaviyo = safeApply {
111111
Registry.unregister<FormLifecycleCallback>()
112112
}
113113

114-
/**
115-
* Check if a form lifecycle callback is currently registered.
116-
*
117-
* @return true if a callback is registered, false otherwise
118-
*/
119-
fun Klaviyo.isFormLifecycleCallbackRegistered(): Boolean {
120-
return Registry.isRegistered<FormLifecycleCallback>()
121-
}
122-
123114
/**
124115
* Check if IAF services are registered in the Klaviyo registry.
125116
*/

sdk/forms/src/test/java/com/klaviyo/forms/FormLifecycleCallbackTest.kt

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ import io.mockk.mockkObject
1313
import io.mockk.verify
1414
import org.junit.After
1515
import org.junit.Assert.assertEquals
16-
import org.junit.Assert.assertFalse
17-
import org.junit.Assert.assertTrue
1816
import org.junit.Before
1917
import org.junit.Test
2018

@@ -46,11 +44,8 @@ internal class FormLifecycleCallbackTest : BaseTest() {
4644
fun `registerFormLifecycleCallback registers callback successfully`() {
4745
val callback = FormLifecycleCallback { _, _ -> }
4846

49-
assertFalse(Klaviyo.isFormLifecycleCallbackRegistered())
50-
5147
Klaviyo.registerFormLifecycleCallback(callback)
5248

53-
assertTrue(Klaviyo.isFormLifecycleCallbackRegistered())
5449
assertEquals(callback, Registry.get<FormLifecycleCallback>())
5550
}
5651

@@ -59,17 +54,12 @@ internal class FormLifecycleCallbackTest : BaseTest() {
5954
val callback = FormLifecycleCallback { _, _ -> }
6055

6156
Klaviyo.registerFormLifecycleCallback(callback)
62-
assertTrue(Klaviyo.isFormLifecycleCallbackRegistered())
6357

6458
Klaviyo.unregisterFormLifecycleCallback()
6559

66-
assertFalse(Klaviyo.isFormLifecycleCallbackRegistered())
60+
assertEquals(null, Registry.getOrNull<FormLifecycleCallback>())
6761
}
6862

69-
@Test
70-
fun `isFormLifecycleCallbackRegistered returns false when no callback registered`() {
71-
assertFalse(Klaviyo.isFormLifecycleCallbackRegistered())
72-
}
7363

7464
@Test
7565
fun `registerFormLifecycleCallback replaces existing callback`() {

0 commit comments

Comments
 (0)