perf(client): remove redundant default instanceof fallback in ORPCError (#1764)

dinwwwh · web-flow · commit 725972b73561 · 2026-08-02T19:15:58.000+07:00
`ORPCError`'s custom `Symbol.hasInstance` no longer falls back to the
default `instanceof` check after the cross-context constructor walk. The
walk already subsumes it: any instance the default check would match
carries this graph's `ORPCError` constructor in its prototype chain, and
that constructor is always registered in the shared WeakSet — so the
fallback could never change the result.

### Performance

- `instanceof` misses (e.g. `e instanceof ORPCError` on a plain `Error`
in catch paths) are ~20% faster: 2.35M → 2.87M ops/sec with a single
dependency graph, 2.01M → 2.41M with multiple graphs.
- Hit paths and cross-context matching behave exactly as before.

### Testing

- New assertions cover the case the removed fallback used to protect:
same-graph and extended instances still match while multiple dependency
graphs are registered.
- Client, contract, and server suites pass (970 tests); lint and
`type:check` clean.
diff --git a/packages/client/src/error.test.ts b/packages/client/src/error.test.ts
@@ -92,6 +92,8 @@ describe('oRPCError', () => {
     expect(new Error('message') instanceof ORPCError).toBe(false)
     expect(new CrossContextORPCError() instanceof ORPCError).toBe(false)
     expect(new ExtendedCrossContextORPCError() instanceof ORPCError).toBe(false)
+    expect(new ORPCError('test') instanceof CrossContextORPCError).toBe(false)
+    expect(new ORPCError('test') instanceof ExtendedCrossContextORPCError).toBe(false)
 
     const constructors: WeakSet<object> = (globalThis as any)[Symbol.for('ORPC_ERROR_CONSTRUCTORS')]
     constructors.add(CrossContextORPCError)
@@ -102,5 +104,14 @@ describe('oRPCError', () => {
     expect(new Error('message') instanceof ORPCError).toBe(false)
     expect(new CrossContextORPCError() instanceof ORPCError).toBe(true)
     expect(new ExtendedCrossContextORPCError() instanceof ORPCError).toBe(true)
+    expect(new ORPCError('test') instanceof CrossContextORPCError).toBe(false)
+    expect(new ORPCError('test') instanceof ExtendedCrossContextORPCError).toBe(false)
+
+    // same-graph instances still match while multiple graphs exist
+    class ExtendedORPCError extends ORPCError<any, any> {}
+    expect(new ORPCError('test') instanceof ORPCError).toBe(true)
+    expect(new ExtendedORPCError('test') instanceof ORPCError).toBe(true)
+    expect(new ExtendedORPCError('test') instanceof ExtendedORPCError).toBe(true)
+    expect(new ORPCError('test') instanceof ExtendedORPCError).toBe(false)
   })
 })
diff --git a/packages/client/src/error.ts b/packages/client/src/error.ts
@@ -131,8 +131,7 @@ export class ORPCError<TCode extends ORPCErrorCode, TData> extends Error {
       }
     }
 
-    // fallback to default instanceof check
-    return super[Symbol.hasInstance](instance)
+    return false
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -131,8 +131,7 @@ export class ORPCError<TCode extends ORPCErrorCode, TData> extends Error {`
`131`	`131`	`}`
`132`	`132`	`}`
`133`	`133`
`134`		`- // fallback to default instanceof check`
`135`		`- return super[Symbol.hasInstance](instance)`
	`134`	`+ return false`
`136`	`135`	`}`
`137`	`136`	`}`
`138`	`137`