Skip to content

[finding] The governed-PR review-request notification channel fails for PRs authored by the os-zhuang seat — "Review cannot be requested from pull request author" #11083

Closed

Description

@os-zhuang

Measured by the skills seat (session session_01MsbKEG4LtERSLaDrbehM3e, 2026-08-22) on the first governed PR of its batch. Filed as finding under the skills-lane self-triage exception; grading next round.

Measured

The ACCEPT path for a governed-surface PR requires requesting review from os-zhuang (the maintainer's notification account — draft-PR review requests push to their phone; ruling 2026-08-19). On PR #11077, authored by a dev dispatched from an os-zhuang seat session, the call fails hard:

update_pull_request(reviewers: ["os-zhuang"]) → 422
"Review cannot be requested from pull request author."

GitHub forbids requesting review from a PR's author. Seats run as several accounts (os-elon, os-warren, huangyiirene, os-sales, os-zhuang…) — so the channel works for most lanes but structurally fails for every governed PR authored under os-zhuang, which includes any seat the maintainer runs interactively under their own account.

Impact

The "awaiting a human merge" push notification never fires for exactly this class; the PR is visible only via the round report and the assignee fallback (assigning the PR to os-zhuang does work and was applied to #11077 as the interim).

Directions (grading input)

  1. Record the assignee fallback as the standing alternative in the ACCEPT-path clause: request review where possible; on the author-identity failure, assign the PR to the maintainer's account instead, and say so in the round report. (Cheapest; protocol text, ratchet-paid.)
  2. Route os-zhuang-seat governed dispatches to a different authoring identity so the review-request channel always works. (Fleet-shape change — maintainer territory.)

Refs: the ACCEPT 路径分叉 clause in .claude/skills/pm-dispatch/SKILL.md · PR #11077 (where measured).

Activity

  1. added
    findingRecorded observation — held, not dispatchable until the findings triage round grades it
    domain:skillsDomain lane — seat card indexed by label:pm:seat
    pm:queueReady for the PM dispatch loop
    and removed
    findingRecorded observation — held, not dispatchable until the findings triage round grades it
    on Aug 22, 2026
  2. os-zhuang commented on Aug 23, 2026

    @os-zhuang
    ContributorAuthor

    Grading (skills seat, session session_01RMTpSRF5CjMmQBFfPtPCwJ, 2026-08-23 concentrated round): promoted finding → pm:queue, scoped to direction 1 — record the assignee fallback in the ACCEPT-path clause (request review where possible; on the author-identity 422, assign the PR to the maintainer's account instead and say so in the round report). Protocol semantics face (.claude/skills/pm-dispatch/SKILL.md) — fable-mandatory construction, ratchet-paid, draft + human merge. Direction 2 (routing governed dispatches to a different authoring identity) is fleet-shape territory and stays with the maintainer; not carried.


    Generated by Claude Code

  3. added
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed
    pm:queueReady for the PM dispatch loop
    on Aug 23, 2026
  4. self-assigned this
    on Aug 23, 2026
  5. os-zhuang commented on Aug 23, 2026

    @os-zhuang
    ContributorAuthor

    Claim: family member — full claim and fold answer live on the anchor #11109 (session session_01RMTpSRF5CjMmQBFfPtPCwJ, branch claude/issue-11109-protocol-text-family, wave 4-B, fable construction). This member's criterion: the ACCEPT-path clause in SKILL.md records the assignee fallback (request review where possible; on the author-identity 422, assign the PR to the maintainer's account and say so in the round report) — ratchet-paid; own commit; Fixes #11083.


    Generated by Claude Code

  6. claude commented on Aug 23, 2026

    @claude
    Contributor

    Delivered as family member in PR #11312 (own commit, own Fixes line); full os-dev report on the anchor #11109.


    Generated by Claude Code


    Generated by Claude Code

  7. removed their assignment
    on Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    domain:skillsDomain lane — seat card indexed by label:pm:seat

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions