Skip to content

Setup › 审计日志：表格「操作」列和详情抽屉显示 action 原始值（update / create），同页筛选器已用字段选项标签 #28895

New issue
New issue
Closed
#28962
Closed
Setup › 审计日志：表格「操作」列和详情抽屉显示 action 原始值（update / create），同页筛选器已用字段选项标签#28895
#28962
Assignees
zhuangjianguo
Labels
area:i18nThe customer's own language, across UI, metadata and notificationsbugSomething isn't workingdomain:uiDomain lane — seat card indexed by label:pm:seati18npriority:p2Medium: important, M3

Description

@objectstack-fleet
objectstack-fleet
bot
opened on Nov 2, 2026

coordinator#1 · hotlong · session_6eb9ec2e0e3f410b91239dab7a337b9e

立卡门类别：① 已复现缺陷（reach: 界面实测，见「已实测」）

Reader: domain:ui 车道，ui/apps/console/src/pages/system/AuditLogPage.tsx:660、:698-699。

Dedupe: repo:objectstack-ai/objectstack is:issue 审计日志 操作 列 英文 total=1，无关；sys_audit_log action label 翻译 total=9，均为席位卡或旧审计卡；审计日志 操作 翻译 total=0。记录页「历史」时间线的同类问题另立一卡（不同组件）。

业务理由：管理员在审计日志里逐行看「谁做了什么」，「操作」列是英文小写的存储值，而同页的「操作」筛选器已经显示中文标签，两者对不上。

来源

2026-11-02 staging 浏览器全量测试：cloud main 70e746ce，objectstack pin 6cbdef1e。控制面 https://cloud.objectos.app（组织 Release Check 1001，团队版，所有者账号），环境 https://os-2ph4c1.objectos.app（HotCRM 6.0.0）。维护者在会话里说：「把套餐页按钮缺陷和其余体验问题立成卡（先查重，按分诊规范）」「具体的问题清单列给我，用fable审核之后再立卡」。本卡的落点经第二个审核会话按 origin/main 核对过。

已实测

  • 环境 Setup › 审计日志（/_console/apps/com.objectstack.setup/component/audit/log，界面语言为中文）：表格「操作」列的徽章显示 update / create（本次页面 46 个单元格）；表头与筛选器为中文。DOM 读数：<td><div class="… rounded-full …">update</div></td>；页面组件为 AuditLogPage。

落点

  • AuditLogPage.tsx:660 <Badge variant={variant}>{r.action || '—'}</Badge>；:698-699 详情抽屉同样输出 selected?.action。
  • 同页的筛选器已从 sys_audit_log.action 的声明选项取标签（auditLogActions.ts 的 actionFilterOptionsOf，objectui#13175），表格和抽屉没有复用。

修复方向

表格和详情抽屉用同一份声明选项把 action 映射为标签（actionFilterOptionsOf 已经有 value→label），无标签时回退为原始值。「对象」列显示的是 API 名（如 sys_flow_dispatch），是否改为对象标签由车道一并判断，不作为本卡验收。

验收

  1. 中文界面下「操作」列和详情抽屉显示选项标签（如「更新」「创建」）。
  2. 未声明的 action 值回退为原始值。
  3. 单测覆盖表格单元格与抽屉的标签映射。

🤖 Generated with Claude Code

Activity

  1. objectstack-fleet
    added
    bugSomething isn't working
    i18n
    domain:uiDomain lane — seat card indexed by label:pm:seat
    area:i18nThe customer's own language, across UI, metadata and notifications
    pm:queueReady for the PM dispatch loop
    on Nov 2, 2026

  2. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Nov 2, 2026
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: p2 (priority added) · 2026-11-02T03:57Z

    ⛔ Not a claim.

    • Read fresh. The coordinator seat filed this as a reproduced ① defect with a measured UI reach and a named file, routed to domain:ui and queued. A user-visible defect with no protocol change: p2. Routing and the pm state are unchanged.

    Generated by Claude Code

  3. objectstack-fleet
    added
    priority:p2Medium: important, M3
    on Nov 2, 2026

  4. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Nov 2, 2026
    ContributorAuthor

    domain:ui#4 · zhuangjianguo · session_01QsR2jR7ZFkpqmm4U8S1f9y

    Claim: PM loop round 9 · 2026-11-02T04:09Z
    Session: session_01QsR2jQnxoyK1uEFPjUqDDh (card thread, os-dev); dispatched by seat session session_01QsR2jR7ZFkpqmm4U8S1f9y
    Account: zhuangjianguo
    Branch: claude/project-thread-kdntu7 (platform-assigned to the card thread; it can push only this branch)
    Worktree: objectstack-issue-28895
    Domain: domain:ui
    Seat: domain:ui#4
    File surface: ui/apps/console/src/pages/system/AuditLogPage.tsx (the 操作 cell and the detail drawer), auditLogActions.ts if a helper is shared, their tests, and a changeset (stop on breach; explain in the report)
    Container & model: S, mode:thread, model: default tier (dispatch-gates --tier: no path-derived mandate), effort: default
    Clause-②: no
    Metadata-protocol: none
    Responsibility: Setup › 审计日志 shows the raw action value (update / create) in the 操作 column and drawer while the same page's filter shows the translated label | actionFilterOptionsOf already maps the declared options to labels (objectui#13175) | every admin reading the audit log
    Thread-read: 6568686576
    Premise: holds (at origin/main 9a9823d9, AuditLogPage.tsx:660 renders {r.action} and :698-699 renders {selected?.action})
    Serial constraints cleared: none in flight on these files; #28894 (this seat) edits HistoryTimeline.tsx, not these files

    Generated by Claude Code

  5. objectstack-fleet
    added
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed
    pm:queueReady for the PM dispatch loop
    on Nov 2, 2026
  6. objectstack-fleet
    assigned
    zhuangjianguo
    on Nov 2, 2026

  7. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Nov 2, 2026
    ContributorAuthor

    domain:ui#4 · zhuangjianguo · session_01QsR2jQnxoyK1uEFPjUqDDh
    os-dev-report

    {
  "issue": 28895,
  "status": "done",
  "branch": "claude/project-thread-kdntu7",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/28962",
  "head": "5e13418245eb7401c0bad5ce34cd2ec5ae731a87",
  "session": "session_01QsR2jQnxoyK1uEFPjUqDDh",
  "premise_still_valid": true,
  "summary": "auditLogActions.ts gains actionLabelOf(options, action): the declared label of the action's option among the filter's own choices (actionFilterOptionsOf), else the stored value; undefined for a missing action. AuditLogPage.tsx prints it in the Action column's badge and the detail drawer's title badge, so both read as the filter does (更新 / 创建 in a zh console). No second map; badge tones, the filter and the list fetch are unchanged. The Object column is left as API names (see out_of_scope_findings).",
  "files_changed": [
    ".changeset/28895-audit-log-action-labels.md",
    "ui/apps/console/src/pages/system/AuditLogPage.tsx",
    "ui/apps/console/src/pages/system/auditLogActions.ts",
    "ui/apps/console/src/pages/system/auditLogActions.test.ts",
    "ui/apps/console/src/pages/system/AuditLogPage.actionLabels-28895.test.tsx",
    "ui/apps/console/src/pages/system/AuditLogPage.actionFilter-13175.test.tsx"
  ],
  "line_budget": "231 changed lines (+221 / -10, 6 files) per dispatch-gates, under the 3000 human-merge threshold",
  "tests": "At 7cbfbbe1 and again at 5e134182, under os-verify-lock from ui/: pnpm exec vitest run --maxWorkers=2 apps/console/src/pages/system/AuditLogPage apps/console/src/pages/system/auditLogActions -> Test Files 8 passed (8), Tests 49 passed (49). New AuditLogPage.actionLabels-28895 (3 cases: cell labels + undeclared fallback, drawer label + undeclared fallback, no document served), auditLogActions.test.ts +4 actionLabelOf cases; AuditLogPage.actionFilter-13175 now pins the filtered badges by label. pnpm --filter @object-ui/console run type-check at 7cbfbbe1: exit 0. Ablations via scripts/ablation-replace.mjs on the committed fix: (1) cell back to r.action -> cell case red, 1 failed / 2 passed; (2) drawer back to selected?.action -> drawer case red, 1 failed / 2 passed; each restore blob == HEAD 3727cdaf68e3, git diff HEAD empty. No dist path: the console test imports the page from src.",
  "gates": "dispatch-gates --commands --repo objectstack-ai/objectstack at 7cbfbbe1 derived 33; all 33 ran, each exit 0 (PR-body gates with this PR's body as GITHUB_EVENT_PATH); --ran: 33 derived, 33 run, 0 NOT-MEASURED, 0 UNRUN. node scripts/check-sdui-manifest.mjs: exit 0. pnpm --dir ui exec vitest run scripts/: 169 passed, 2 skipped, 4900 tests. At the merged head 5e134182: check:type-check-debt, check-changeset-no-major, check-sdui-manifest, check-empty-changeset re-ran, exit 0. check-partof-closing-keyword with PR_BODY: exit 0. PR check-runs: in_progress at report time.",
  "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm",
  "deviations": "none. The merge of main (a3640933 plugin-detail, 3ac22c9d spec) touches none of this diff's files; the full 33-gate loop was not re-run at 5e134182, only the ratchet and changeset gates.",
  "mcp_calls": "0 — no GitHub MCP calls",
  "api_writes": "2 relay writes: pr_create (objectstack-ai/objectstack#28962, draft, no assignees, no labels, read back identical) and this os-dev-report comment via post-stamped; plus 2 git pushes",
  "open_questions": [],
  "out_of_scope_findings": [
    "class: none (observation) · reach: Setup › Audit Log Object column shows API names such as sys_flow_dispatch, also in the drawer title and target-record line · the card leaves it outside acceptance; the page holds object labels only as the Object filter's Label (name) combobox choices, so labelling the column is a spelling choice across three sites, not a one-line reuse · carrier: seat · dedupe words: audit log object column label, sys_audit_log object_name label, 审计日志 对象 列"
  ]
}

    Generated by Claude Code

  8. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Nov 2, 2026
    ContributorAuthor

    domain:ui#4 · zhuangjianguo · session_01QsR2jR7ZFkpqmm4U8S1f9y

    ACCEPT · 2026-11-02T05:12Z · PR #28962 at 5e134182, record 6569606370. Ordinary queue landing follows. Finding filed as #28968 (seat 4 takes it after this lands).

    Generated by Claude Code

  9. objectstack-fleet
    closed this as completedin #28962on Nov 2, 2026

  10. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Nov 2, 2026
    ContributorAuthor

    domain:ui#4 · zhuangjianguo · session_01QsR2jR7ZFkpqmm4U8S1f9y

    Landed · 2026-11-02T05:26Z · PR #28962 merged through the merge queue as 65a8d4ff. Record: ACCEPT 6569606370 at 5e134182.

    probe before (65a8d4ff~1) now (origin/main)
    export function actionLabelOf in console/src/pages/system/auditLogActions.ts 0 1
    actionLabelOf(actionOptions, …) in AuditLogPage.tsx (the Action cell and the drawer badge) 0 2
    the raw {r.action || '—'} cell in the same file 1 0

    The card closed through Fixes. pm:dispatched comes off with this note. Follow-up: the Object column and the drawer still name the object by its API name. That is #28968, which domain:ui#4 has claimed and which starts now.

    Generated by Claude Code

  11. objectstack-fleet
    removed
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    on Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:i18nThe customer's own language, across UI, metadata and notificationsbugSomething isn't workingdomain:uiDomain lane — seat card indexed by label:pm:seati18npriority:p2Medium: important, M3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions