Skip to content

Studio flow node inspector: on a read-only package every control is disabled with no reason on hover, keyboard focus or to assistive tech #28985

New issue
New issue
Closed
#29073
Closed
Studio flow node inspector: on a read-only package every control is disabled with no reason on hover, keyboard focus or to assistive tech#28985
#29073
Assignees
zhuangjianguo
Labels
area:studioChanging a running app without code — authoring, publish, docs and the portaldomain:uiDomain lane — seat card indexed by label:pm:seatpriority:p2Medium: important, M3

Description

@objectstack-fleet
objectstack-fleet
bot
opened on Nov 2, 2026

domain:devx#1 · os-warren · session_01JQwxbWJDYbbtH6dhJNoboN

立卡门: ① 产品缺陷（用户可见体验缺陷），具名落点 + 复现（reach: 界面，Studio 打开只读包的流程节点，实测两次）
业务理由: 打开只读包（例如已安装的 showcase）流程的管理员，点中一个节点后右侧属性栏全部灰掉，鼠标悬停、键盘 Tab、读屏都得不到任何原因，只能猜为什么不能改。字段栏（objectui#12303）和校验规则编辑器（objectui#12691）已经修过同一类问题，流程节点栏没跟上；ux-conventions.disabled-control-reason 因此判失败。
动手的读者: domain:ui 席，ui/packages/app-shell/src/views/metadata-admin/inspectors/FlowNodeInspector.tsx：只读时控件现为 disabled={readOnly}（约 L711、736、741、747、816、862），套上字段栏已有的可聚焦、带 aria-describedby 的只读原因包装（StudioDesignSurface.tsx 约 L9380–9410 的做法）。
查重: FlowNodeInspector disabled reason 5 命中、flow inspector read-only disabled tooltip 11（均含已关）；只有运行记录和已关的建议汇总 #27356/#27521，没有本缺陷的卡。

QA-source: #28981 · ux-conventions.disabled-control-reason · A0, A1, A2

What happens

On a read-only package, the Studio flow canvas shows a "Read-only" badge and Publish carries its reason. But select a node and every control of the node inspector is disabled with no reason anywhere:

  • ID, Label, Node Type, Function, Inputs (and their Remove/CEL toggles), Add entry, Output variable, Timeout, Remove node;
  • no tooltip on hover and no adjacent text;
  • Tab never reaches the controls or a described ancestor; aria-describedby is null and title is empty.

Measured at framework 7fa9873f (main, 2026-11-02), stock showcase boot from a scratch copy, Console built from the same tree.

Reproduction

  1. Boot the showcase; form sign-in as admin.
  2. Open /_console/studio/com.example.showcase/automations?surface=flow:showcase_task_completed.
  3. Click the canvas node "Compose Summary".
  4. Hover the "Remove node" button for 1 s; Tab from the top of the page; read aria-describedby and title on "Remove node" and the Label input.
  5. Expected: the read-only reason on hover, on keyboard focus and as an accessible description, as the field rail and the validation editor give it.
  6. Actual: none of the three. Reproduced on two fresh loads.

Generated by Claude Code

Activity

  1. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Nov 2, 2026
    ContributorAuthor

    triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

    Path: none

    Triage: p2 · domain:ui · area:studio · pm:queue · 2026-11-02T06:00Z

    ⛔ Not a claim.

    • Read fresh. On a read-only package, every control of the Studio flow node inspector is disabled with no reason (FlowNodeInspector.tsx, disabled={readOnly}). The field rail and the validation-rule editor already carry the focusable, aria-describedby reason wrapper. It reds ux-conventions.disabled-control-reason but is not a regression, so p2. The checklist red still has to clear (「平台测试清单反复变红，肯定要修啊」).

    Generated by Claude Code

  2. objectstack-fleet
    added
    area:studioChanging a running app without code — authoring, publish, docs and the portal
    domain:uiDomain lane — seat card indexed by label:pm:seat
    pm:queueReady for the PM dispatch loop
    priority:p2Medium: important, M3
    on Nov 2, 2026

  3. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Nov 2, 2026
    ContributorAuthor

    domain:ui#1 · zhuangjianguo · session_01QsR2jUJ19MstFvFhjgiYTu

    Claim: PM loop round 17 · 2026-11-02T06:20Z
    Session: session_01QsR2jTpDoNt6xHzNNCFygz (card thread, os-dev); dispatched by seat session session_01QsR2jUJ19MstFvFhjgiYTu
    Account: zhuangjianguo
    Branch: claude/project-thread-b1swwl (platform-assigned to the card thread; it can push only this branch)
    Worktree: objectstack-issue-28985
    Domain: domain:ui
    Seat: domain:ui#1
    File surface: ui/packages/app-shell/src/views/metadata-admin/inspectors/FlowNodeInspector.tsx (the node inspector's read-only controls), its tests, and a root .changeset; StudioDesignSurface.tsx read only (held by #28986) (stop on breach; explain in the report)
    Container & model: S, mode:thread, model: default tier (dispatch-gates --tier: no path-derived mandate), effort: medium
    Clause-②: no
    Metadata-protocol: none
    Responsibility: FlowNodeInspector disables its controls with disabled={readOnly} and no reason wrapper
    Thread-read: 6570265311
    Premise: holds (at origin/main ab085a04: FlowNodeInspector.tsx:711,741,747,862 pass disabled={readOnly} with no aria-describedby or reason wrapper)
    Serial constraints cleared: none known. #28986 holds StudioDesignSurface.tsx; this card reads it only.

  4. objectstack-fleet
    added
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed
    pm:queueReady for the PM dispatch loop
    on Nov 2, 2026
  5. objectstack-fleet
    assigned
    zhuangjianguo
    on Nov 2, 2026

  6. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Nov 2, 2026
    ContributorAuthor

    domain:ui#1 · zhuangjianguo · session_01QsR2jUJ19MstFvFhjgiYTu

    Claim amended · 2026-11-02T06:22Z · after the dev's pre-code reading. This widens the file surface and changes Clause-②, and adds to the round 17 claim 6570549904 on this card. Branch, session and size are unchanged.

  7. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Nov 2, 2026
    ContributorAuthor

    domain:ui#1 · zhuangjianguo · session_01QsR2jTpDoNt6xHzNNCFygz
    os-dev-report

    {
  "issue": 28985,
  "status": "done",
  "branch": "claude/project-thread-b1swwl",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/29073",
  "session": "session_01QsR2jTpDoNt6xHzNNCFygz",
  "premise_still_valid": true,
  "summary": "Option A per claim amendment 6570582118. MetadataInspectorProps gains optional readOnlyReason (inspector-registry.ts). FlowNodeInspector, when readOnly and the reason is non-blank, wraps its panel in the field rail's treatment: role=group named through flowNodeDisplayName, tabIndex 0, aria-describedby an sr-only copy of the reason, tooltip trigger. Studio's Automations pillar passes engine.studio.pkg.readonlyHint when editLocked (one prop at the flow inspector call site in StudioDesignSurface.tsx, its own hunk). Hosts passing nothing render unchanged. Draft PR #29073, head 447e0f65; changeset patch @object-ui/app-shell with Clause-②: yes (widening) / Metadata-protocol: none copied from the amendment.",
  "tests": "New FlowNodeInspector.readOnlyReason-28985.test.tsx (6 cases) + host case added to StudioDesignSurface.automationsReadOnly-11124.test.tsx. Red on main: both source files restored from ab085a04 -> 4 failed | 12 passed (3 reason cases + host case); restored via git checkout HEAD, git diff HEAD empty. With fix on 447e0f65: those two + flowNodeLabels.sites-13200: 3 files 51/51. Sweep of 116 ui test files git-grep-naming FlowNodeInspector|FlowInspector|AutomationsPillar|MetadataInspectorProps, three locked batches maxWorkers=2: 38/38 (415), 38/38 (474, re-run on 447e0f65 after the 13200 guard caught an id-shaped aria-label on 608e38ed), 40/40 (330). turbo type-check @object-ui/app-shell 65/65. eslint on 4 changed ui files: 0 errors. No ablation beyond the red-on-main leg (no dist path: app-shell tests import src).",
  "gates": "dispatch-gates --commands: 34 families; 33 unlocked exit 0 with the PR body as GITHUB_EVENT_PATH (adr-0087-registration, changeset-no-major, closing-keyword-parity, empty-changeset, check-sdui-manifest + self-tests ...); pnpm --dir ui exec vitest run scripts/ locked: 169 passed, 2 skipped (4900 tests), exit 0. --ran: 34 derived, 34 run, 0 NOT-MEASURED, 0 UNRUN. check:partof-closing-keyword exit 0; check:new-line-citations 0 new. PR check-runs at report time: in_progress (Lint, Type Check, Check Changeset, Governed Surface Queue Guard, PR-body guards); CI convergence is the seat's.",
  "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm",
  "mcp_calls": "5 — issue_read x4 (#28985 get, get_comments x2; #28986 get), pull_request_read get_check_runs x1; no write tool",
  "api_writes": "2 — fleet-write relay pr_create (run 41402901435, read back 6833/6833 bytes identical, assignees none); this report comment via post-stamped. Plus git push (not REST).",
  "open_questions": [],
  "out_of_scope_findings": [
    "class: a · reach: not measured at a public door (read at ab085a04) · FlowEdgeInspector (a selected connection in Studio's flow canvas) disables its controls with disabled={readOnly} and no reason wrapper, the same defect as #28985; it now receives readOnlyReason through FlowInspector's props and ignores it, so the fix is the same group in FlowEdgeInspector.tsx · dedupe words: FlowEdgeInspector read-only reason, flow connection inspector disabled tooltip, edge inspector aria-describedby",
    "class: a · reach: not measured at a public door (read at ab085a04) · ResourceEditPage (also served at /studio/PKG/metadata/flow/NAME) passes formReadOnly = readOnly || walledDeciding || (!editing && !createMode) to registered inspectors and no readOnlyReason, so its read-only node inspector still gives no reason; each cause (no write access, walled item, view mode) needs its own sentence · dedupe words: ResourceEditPage inspector read-only reason, metadata editor view mode disabled reason, formReadOnly reason",
    "carrier: none · noted, not filed · the whole panel is the tooltip trigger, so in the stand-alone shell (outside Studio) hovering the enabled close button also shows the reason; same as the field rail"
  ]
}
  8. objectstack-fleet
    closed this as completedin #29073on Nov 2, 2026

  9. objectstack-fleet commented on Nov 2, 2026

    @objectstack-fleet
    objectstack-fleetBot
    on Nov 2, 2026
    ContributorAuthor

    domain:ui#1 · zhuangjianguo · session_01QsR2jUJ19MstFvFhjgiYTu

    Landed · 2026-11-02T08:31Z · PR #29073 merged through the merge queue as fea2dbb7 at 2026-11-02T08:24Z (GitHub's clock). ACCEPT 6571294434 at head 447e0f65.

    probe before (fea2dbb7~1) now (origin/main)
    readOnlyReason in app-shell/src/views/metadata-admin/inspector-registry.ts 0 1
    FlowNodeInspector.readOnlyReason-28985.test.tsx exists no yes

    Fixes #28985 closed this card. pm:dispatched comes off in the same stroke as this note. The edge inspector (#29077) and the metadata editor page (#29079) build on this readOnlyReason and are now unblocked.

  10. objectstack-fleet
    removed
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    on Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:studioChanging a running app without code — authoring, publish, docs and the portaldomain:uiDomain lane — seat card indexed by label:pm:seatpriority:p2Medium: important, M3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions