Feature Request: Extend labels with runner group information in the workflow_job webhook #53420 #158000
Replies: 3 comments
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for reopening this! I would also love to see the |
Beta Was this translation helpful? Give feedback.
-
|
Are there any plans to add the runner group to It's okay if not, we just need to know so we can close issues in projects we manage that await at least a decision on this. If the plan is to encourage people to just migrate to scale sets, that's also fine. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
Product Feedback
Body
Reopening #53420
The webhook payload sent when a job is initially triggered always has
workflow_job.runner_group_id&workflow_job.runner_group_nameset tonull. This is documented:https://docs.github.com/en/webhooks/webhook-events-and-payloads#workflow_job
This makes sense(?), in the sense that the runner's group cannot be determined until the job is placed onto a runner. The use case for including runner metadata in the
workflow_jobevent isn't obvious, I suspect it is to match the schema of https://docs.github.com/en/rest/actions/workflow-jobs?apiVersion=2022-11-28#get-a-job-for-a-workflow-run. Which itself is probably designed like that to keep the logic simple for a GitHub web UI view.But back to the webhook event: the group requested by the job is a static value, set in the job's
runs-onin the workflow file, so can be determined as soon as the job is triggered. Please include the requested group in the webhook event payload, with a suggested location ofworkflow_run.group. This would match the behaviour for labels, where the webhook payload includes the requested labels, but not the actual labels of the allocated runner.Use case
We have a few different systems for managing self-hosted runners, and we'd like to keep the runner labels the same between systems. This lets us have something like a
productiongroup and anexperimentalgroup, and move jobs between them as needed. At the moment, we're using an array of labels likeAnd configuring the webhook endpoints for the systems to ignore deliveries when the
grouplabel doesn't match. If the requested group were available in the webhook payload, there would be no functional change. We'd just update the syntax to:And our systems would then filter deliveries by inspecting the payload's
workflow_job.groupinstead.What would make a difference is in managing and monitoring the systems, as we could easily control which repositories/workflows could use these systems via the existing runner group management UI.
Beta Was this translation helpful? Give feedback.
All reactions