Merge pull request #51627 from shes50103/strict-loading-not-raising-when-pluck

rafaelfranca · web-flow · commit b0ed7ac93ce2 · 2026-05-14T16:11:29.000-04:00
[Fix #51524] Fix `strict_loading` violations ignored when using `pluck`
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md
@@ -1,3 +1,7 @@
+*   Fix `strict_loading` violations ignored when using `pluck`
+
+    *Johnson Chan*
+
 *   Move the defaulting of `prevent_writes` to `true` when using the `reading` role into the parameters
     of the role switching methods, and raise an `ArgumentError` if `prevent_writes: false` is provided
     with the `reading` role.
diff --git a/activerecord/lib/active_record/associations/association.rb b/activerecord/lib/active_record/associations/association.rb
@@ -232,6 +232,18 @@ def create!(attributes = nil, &block)
         _create_record(attributes, true, &block)
       end
 
+      def violates_strict_loading?
+        return unless find_target?
+
+        return if @skip_strict_loading
+
+        return unless owner.validation_context.nil?
+
+        return reflection.strict_loading? if reflection.options.key?(:strict_loading)
+
+        owner.strict_loading? && !owner.strict_loading_n_plus_one_only?
+      end
+
       # Whether the association represents a single record
       # or a collection of records.
       def collection?
@@ -281,16 +293,6 @@ def skip_strict_loading(&block)
           @skip_strict_loading = skip_strict_loading_was
         end
 
-        def violates_strict_loading?
-          return if @skip_strict_loading
-
-          return unless owner.validation_context.nil?
-
-          return reflection.strict_loading? if reflection.options.key?(:strict_loading)
-
-          owner.strict_loading? && !owner.strict_loading_n_plus_one_only?
-        end
-
         # The scope for this association.
         #
         # Note that the association_scope is merged into the target_scope only when the
diff --git a/activerecord/lib/active_record/associations/collection_proxy.rb b/activerecord/lib/active_record/associations/collection_proxy.rb
@@ -726,6 +726,10 @@ def calculate(operation, column_name)
       end
 
       def pluck(*column_names)
+        if proxy_association.violates_strict_loading?
+          Base.strict_loading_violation!(owner: proxy_association.owner.class, reflection: proxy_association.reflection)
+        end
+
         null_scope? ? scope.pluck(*column_names) : super
       end
 
diff --git a/activerecord/test/cases/strict_loading_test.rb b/activerecord/test/cases/strict_loading_test.rb
@@ -355,6 +355,25 @@ def test_strict_loading_with_has_one_through_does_not_prevent_creation_of_associ
     end
   end
 
+  def test_on_lazy_loading_and_strict_loading_with_pluck
+    with_strict_loading_by_default(Developer) do
+      dev = Developer.first
+
+      assert_raises ActiveRecord::StrictLoadingViolationError do
+        dev.audit_logs.pluck(:id)
+      end
+    end
+  end
+
+  def test_preload_audit_logs_are_strict_loading_with_pluck
+    with_strict_loading_by_default(Developer) do
+      dev = Developer.preload(:audit_logs).first
+
+      assert_nothing_raised do
+        dev.audit_logs.pluck(:id)
+      end
+    end
+  end
 
   def test_preload_audit_logs_are_strict_loading_because_parent_is_strict_loading
     developer = Developer.first
