Skip to content

feat: infer parameter types from function call return types #4326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noxymon wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: infer parameter types from function call return types #4326

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e2ba51
feat: infer parameter types from function call return types in compar…
noxymon Mar 5, 2026
b634f95
fix: improve function return type resolution to correctly handle 'any…
noxymon Mar 6, 2026
c5d3dfd
ad guardrails when infer parameter names from column references when …
noxymon Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ad guardrails when infer parameter names from column references when … 
…`ref.name` is empty.
  • Loading branch information
@noxymon
noxymon committed Mar 6, 2026
commit c5d3dfdecd4e5f6efe6bee2cf51c42ce35fbcc62
17 changes: 16 additions & 1 deletion internal/compiler/resolve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,22 @@ func (comp *Compiler) resolveCatalogRefs(qc *QueryCatalog, rvs []*ast.RangeVar,
if funcCallSide != nil {
fun, ferr := c.ResolveFuncCall(funcCallSide)
if ferr == nil && fun.ReturnType != nil && !strings.HasPrefix(fun.ReturnType.Name, "any") && fun.ReturnType.Name != "record" {
defaultP := named.NewInferredParam(ref.name, true)
paramName := ref.name
if paramName == "" {
fcList := astutils.Search(funcCallSide, func(node ast.Node) bool {
_, ok := node.(*ast.ColumnRef)
return ok
})
if len(fcList.Items) > 0 {
if cr, ok := fcList.Items[0].(*ast.ColumnRef); ok {
items := stringSlice(cr.Fields)
if len(items) > 0 {
paramName = items[len(items)-1]
}
}
}
}
defaultP := named.NewInferredParam(paramName, true)
p, isNamed := params.FetchMerge(ref.ref.Number, defaultP)
a = append(a, Parameter{
Number: ref.ref.Number,
Expand Down
Loading