Merged
Conversation
includes docs and tests
Member
|
@stratoukos Great work on this commit. One thing is missing, what about cases where ======================================================================
FAIL: test_window_index (tmuxp.testsuite.test_workspacebuilder.WindowIndexTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/tony/workspace/tmuxp/tmuxp/testsuite/test_workspacebuilder.py", line 500, in test_window_index
self.assertEqual(window['window_index'], expected_index)
AssertionError: u'1' != '0'
---------------------------------------------------------------------- |
Author
|
Yeah, this didn't cross my mind, since the test suite passed with my I'll look into it and follow up shortly. On 5 Dec 2013, at 17:29, Tony Narlock wrote:
|
Author
|
This commit passes all test with any |
Member
|
@stratoukos: Thank you. Merging this. I am going to bump to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a window_index option so that you can specify a window's index.
This is very useful for me, since I like to have some windows that I don't interact a lot with (running servers or tailing log files) on the "right side" of the keyboard (indexes 8-9).