Conversation
Codecov Report
@@ Coverage Diff @@
## v1.6.x #647 +/- ##
==========================================
+ Coverage 73.83% 74.19% +0.36%
==========================================
Files 7 7
Lines 1055 1062 +7
Branches 269 271 +2
==========================================
+ Hits 779 788 +9
+ Misses 202 200 -2
Partials 74 74
Continue to review full report at Codecov.
|
tony
left a comment
There was a problem hiding this comment.
Nice @joseph-flinn !
The logger does such a good job it preserves colors:
tmuxp load ~/work/python/libtmux --log-file ~/mylog.log
In another tab:
cat mylog.log
~ ❯ cat mylog.log
(INFO) [15:11:15] tmuxp.cli [Loading] /home/t/work/python/libtmux/.tmuxp.yaml
- Should we add an ability to control log level? I don't think one is available is it?
- Should we add an option to stripe formatting?
cat looks beautiful, but for the text itself in an editor:
^[[0m^[[32m^[[1m(INFO)^[[0m [^[[30m^[[2m^[[1m15:11:15^[[39m^[[0m] ^[[37m^[[2m^[[1mtmuxp.cli^[[39m^[[0m ^[[0m [Loading] /home/t/work/python/libtmux/.tmuxp.yaml
I also just remembered that I forgot to update the README and other supporting documentation. I'll go ahead and do that as well |
|
@joseph-flinn Sorry for the delay! I may be busy on the weekend for a week or two (errands on my end!) Merged in v1.6.3 and v1.7.0a3! 1.6.3: http://localhost:8031/history.html#tmuxp-1-6-3-2020-11-22, https://pypi.org/project/tmuxp/1.6.3/ 1.7.0a3: http://localhost:8031/history.html#tmuxp-1-7-0a3-2020-11-22, https://pypi.org/project/tmuxp/1.7.0a3/ |
|
No worries! I'll probably be a bit busy for the next couple weekends as
well, but will put some work in when I can.
…On Sun, Nov 22, 2020, 12:37 Tony Narlock ***@***.***> wrote:
@joseph-flinn <https://github.com/joseph-flinn> Sorry for the delay! I
may be busy on the weekend for a week or two (errands on my end!)
Merged in v1.6.3 and v1.7.0a3!
1.6.3: http://localhost:8031/history.html#tmuxp-1-6-3-2020-11-22,
https://pypi.org/project/tmuxp/1.6.3/
1.7.0a3: http://localhost:8031/history.html#tmuxp-1-7-0a3-2020-11-22,
https://pypi.org/project/tmuxp/1.7.0a3/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#647 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN5KNNOKMJQOYWFQXTYBWSDSRFY7RANCNFSM4TWL7PUA>
.
|
|
@joseph-flinn Sounds good! |
Adding the
--log-fileoption to theloadcommand.(As discussed over email. There isn't a specific issue for the addition)