Conversation
Codecov Report
@@ Coverage Diff @@
## master #812 +/- ##
==========================================
- Coverage 74.98% 74.96% -0.02%
==========================================
Files 18 18
Lines 1395 1394 -1
Branches 334 334
==========================================
- Hits 1046 1045 -1
Misses 263 263
Partials 86 86
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Handles: - doctests in markdown - linkifying issues in changelog - rendering table of contents for sphinx.ext.autodoc directives And we can remove sphinx-autoapi
9af3e82 to
72783b3
Compare
Remove sphinx-autoapi, which has broken imports. The only purpose this module had was showing table of contents. The tradeoff was a lot of difficult to track, subtle bugs. Also move to linkify_issues. A much simpler and more concise issue linker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Render changelog in
linkify_issuesFix Table of contents rendering with sphinx autodoc with
sphinx_toctree_autodoc_fixDeprecate
sphinx-autoapi, per above fixing the table of contents issueThis also removes the need to workaround autoapi bugs.
Test doctests in our docs via
pytest_doctest_docutils(built ondoctest_docutils)Sphinx-click issue
Fixed via
gp-libsv0.0.1a10git-pull/gp-libs#11