Skip to content

Fix uninstall scripts#1221

Merged
jgebal merged 1 commit intodevelopfrom
jgebal-patch-1
Aug 8, 2022
Merged

Fix uninstall scripts#1221
jgebal merged 1 commit intodevelopfrom
jgebal-patch-1

Conversation

@jgebal
Copy link
Member

@jgebal jgebal commented Jul 28, 2022

Fixing problem with uninstall script buffer overflow on DBMS_OUTPUT.
Resolves: #1220

@jgebal
Fix uninstall scripts
4f944a6 
Fixing problem with uninstall script buffer overflow on DBMS_OUTPUT.
Reolves: #1220
@jgebal jgebal added this to the 3.1.13 milestone Jul 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2022 •
edited
Loading

Unit Test Results

       1 files         2 suites   4m 31s ⏱️
1 025 tests 1 020 ✔️ 4 💤 0 ❌ 1 🔥
1 028 runs  1 019 ✔️ 8 💤 0 ❌ 1 🔥

For more details on these errors, see this check.

Results for commit 4f944a6.

♻️ This comment has been updated with latest results.

@kukimik
Copy link
Contributor

kukimik commented Jul 28, 2022 •
edited
Loading

Note that with serveroutput turned off, failure to drop a synonym is likely to get unnoticed. See the error handling in uninstall_synonyms.sql:

utPLSQL/source/uninstall_synonyms.sql

Line 22 in fc5c4af

exception
,

utPLSQL/source/uninstall_synonyms.sql

Line 55 in fc5c4af

exception
- the exceptions are silenced.

By the way, also this i := i + 1; should be put after execute immediate succeeds. Maybe it can also be fixed here. Mentioning any failures in the summaries ( dbms_output.put_line(i||' synonyms dropped');) could also be helpful.

@jgebal
Copy link
Member Author

jgebal commented Jul 29, 2022

Note that with serveroutput turned off,...

It won't as the output is enabled as unlimited inthis script.
https://github.com/utPLSQL/utPLSQL/blob/develop/source/uninstall.sql#L17
https://github.com/utPLSQL/utPLSQL/blob/develop/source/define_ut3_owner_param.sql#L17

@jgebal jgebal merged commit bffce59 into develop Aug 8, 2022
@jgebal jgebal deleted the jgebal-patch-1 branch August 15, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.1.13

Development

Successfully merging this pull request may close these issues.

Uninstall script: buffer overflow error

2 participants

@jgebal @kukimik