fix: session object was never used in aiohttp request (#700) by greshilov · Pull Request #701 · googleapis/google-auth-library-python

greshilov · 2021-02-16T15:46:14Z

Fix for #700

google-cla · 2021-02-16T15:46:19Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

greshilov · 2021-02-16T15:47:18Z

@googlebot I signed it!

arithmetic1728 · 2021-05-06T08:16:04Z

+        # TODO: Use auto_decompress property for aiohttp 3.7+
+        if session is not None and session._auto_decompress:
+            raise ValueError(
+                "Client sessions with auto_decompress=True are not supported."


why raise the error here?

Modifying the session object provided by the user is inappropriate in this place, so we can't disable auto_decompress ourselves. Remaining options are:

Ignore the session object provided by the user and leave the self.session = None. Log error in console.

Raise the error to stop execution and warn user, that's something went wrong with one's session.

I chose the latter option because it's better to fail early in my opinion. A user may not notice that one's session object is ignored.

Sorry I meant why auto_decompress=True are not supported. I am not familiar with aiohttp.

I think in this PR you also need to pass auto_decompress=False to https://github.com/googleapis/google-auth-library-python/blob/master/system_tests/system_tests_async/conftest.py#L29 to make the system test work.

Sorry I meant why auto_decompress=True are not supported. I am not familiar with aiohttp.

I think in this PR you also need to pass auto_decompress=False to https://github.com/googleapis/google-auth-library-python/blob/master/system_tests/system_tests_async/conftest.py#L29 to make the system test work.

Ah, auto_decompress=True is supported by aiohttp, but this library prefers to do decompression on its own:

google-auth-library-python/google/auth/transport/_aiohttp_requests.py

Lines 80 to 88 in 04c870a

async def content(self):

# Load raw_content if necessary

await self.raw_content()

if self._is_compressed():

decoder = urllib3.response.MultiDecoder(

self._response.headers["Content-Encoding"]

)

decompressed = decoder.decompress(self._raw_content)

return decompressed

I've made required changes in conftest.py.

Ah I see. Thank you! The system test is still failing. I will take a look at why it failed.

…pis#700)

…oogleapis#700)

greshilov · 2021-06-02T21:06:48Z

@arithmetic1728 I hope I found the problem. ASYNC_REQUESTS_SESSION is created outside the pytest-asyncio context and thus assigned to the wrong event loop.

ASYNC_REQUESTS_SESSION = aiohttp.ClientSession(auto_decompress=False)

I moved the session creation process to a separate fixture. Hope it helps.

arithmetic1728 · 2021-06-03T07:44:22Z

@greshilov Great! Thank you!

greshilov requested a review from a team February 16, 2021 15:46

google-cla Bot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 16, 2021

google-cla Bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 16, 2021

fix: session object was never used in aiohttp request (googleapis#700)

dfb2440

greshilov force-pushed the fix-request-session-arg branch from 804c4d3 to dfb2440 Compare February 16, 2021 20:57

Merge branch 'master' into fix-request-session-arg

556ca83

arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2021

arithmetic1728 approved these changes May 6, 2021

View reviewed changes

arithmetic1728 reviewed May 6, 2021

View reviewed changes

arithmetic1728 requested review from arithmetic1728 and crwilcox May 6, 2021 08:16

fixup! fix: session object was never used in aiohttp request (googlea…

baf7d0c

…pis#700)

arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2021

greshilov and others added 2 commits June 2, 2021 23:58

fixup! fixup! fix: session object was never used in aiohttp request (g…

a8137c9

…oogleapis#700)

Merge branch 'master' into fix-request-session-arg

0de9cd1

arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2021

arithmetic1728 approved these changes Jun 3, 2021

View reviewed changes

arithmetic1728 merged commit 09e0389 into googleapis:master Jun 3, 2021

greshilov mentioned this pull request Jun 8, 2021

Session argument for aiohttp request object is ignored #700

Closed

busunkim96 mentioned this pull request Nov 10, 2021

Turn on snippetgen by default googleapis/gapic-generator-python#1043

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: session object was never used in aiohttp request (#700)#701

fix: session object was never used in aiohttp request (#700)#701
arithmetic1728 merged 5 commits into
googleapis:masterfrom
greshilov:fix-request-session-arg

greshilov commented Feb 16, 2021

Uh oh!

google-cla Bot commented Feb 16, 2021

Uh oh!

greshilov commented Feb 16, 2021

Uh oh!

arithmetic1728 May 6, 2021

Uh oh!

greshilov May 6, 2021

Uh oh!

arithmetic1728 May 6, 2021

Uh oh!

greshilov May 6, 2021

Uh oh!

arithmetic1728 May 7, 2021

Uh oh!

greshilov commented Jun 2, 2021

Uh oh!

arithmetic1728 commented Jun 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	async def content(self):
	# Load raw_content if necessary
	await self.raw_content()
	if self._is_compressed():
	decoder = urllib3.response.MultiDecoder(
	self._response.headers["Content-Encoding"]
	)
	decompressed = decoder.decompress(self._raw_content)
	return decompressed

Conversation

greshilov commented Feb 16, 2021

Uh oh!

google-cla Bot commented Feb 16, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

greshilov commented Feb 16, 2021

Uh oh!

arithmetic1728 May 6, 2021

Choose a reason for hiding this comment

Uh oh!

greshilov May 6, 2021

Choose a reason for hiding this comment

Uh oh!

arithmetic1728 May 6, 2021

Choose a reason for hiding this comment

Uh oh!

greshilov May 6, 2021

Choose a reason for hiding this comment

Uh oh!

arithmetic1728 May 7, 2021

Choose a reason for hiding this comment

Uh oh!

greshilov commented Jun 2, 2021

Uh oh!

arithmetic1728 commented Jun 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants