Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

docs: add GEOGRAPHY data type code samples#428

Merged
tswast merged 2 commits into
googleapis:masterfrom
tswast:b171804665-geography
Dec 9, 2020
Merged

docs: add GEOGRAPHY data type code samples#428
tswast merged 2 commits into
googleapis:masterfrom
tswast:b171804665-geography

Conversation

@tswast

@tswast tswast commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

These are added to a separate directory in order to isolate the GeoJSON
and WKT dependencies from the other code samples.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal 171804665

These are added to a separate directory in order to isolate the GeoJSON
and WKT dependencies from the other code samples.
@tswast tswast requested a review from a team as a code owner December 9, 2020 19:50
@tswast tswast requested review from tmatsuo and removed request for a team December 9, 2020 19:50
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Dec 9, 2020
@snippet-bot

snippet-bot Bot commented Dec 9, 2020

Copy link
Copy Markdown

Here is the summary of changes.

You added 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2020
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Dec 9, 2020
@tswast tswast requested review from shollyman and steffnay December 9, 2020 19:56
@tswast tswast requested a review from a team December 9, 2020 20:10
Comment thread tests/system.py
SELECT name, SUM(number) AS total_people
FROM `bigquery-public-data.usa_names.usa_1910_current`
GROUP BY name
SELECT COUNT(*)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really associated with this sample, but the system test flaked, so I figured I'd swap out this query with one from go/bq-long-queries

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@shollyman shollyman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was today years old when I found out that streaming inserts will accept either WKT or geojson as the field contents.

Comment thread tests/system.py
SELECT name, SUM(number) AS total_people
FROM `bigquery-public-data.usa_names.usa_1910_current`
GROUP BY name
SELECT COUNT(*)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

import nox


# WARNING - WARNING - WARNING - WARNING - WARNING

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tswast tswast merged commit dbc68b3 into googleapis:master Dec 9, 2020
@tswast tswast deleted the b171804665-geography branch December 9, 2020 22:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants