Skip to content

Message feature update - #313

Merged
RhysSullivan merged 30 commits into
AnswerOverflow:mainfrom
JoltCode:message-feature-update
Apr 8, 2023
Merged

Message feature update#313
RhysSullivan merged 30 commits into
AnswerOverflow:mainfrom
JoltCode:message-feature-update

Conversation

@JoltCode

@JoltCode JoltCode commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

Description

Adds the following message features:

  • Modal for image attachments

Fixes #84 (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

N/A - UI

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated .env.example if I added a new environment variable
  • My PR title follows the semantic commits style

@vercel

vercel Bot commented Mar 30, 2023 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
answer-overflow-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2023 7:36pm

@vercel

vercel Bot commented Mar 30, 2023

Copy link
Copy Markdown

@JoltCode is attempting to deploy a commit to the AnswerOverflow Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added ⚛ component Issue relates to a react component 🖥️website Relates to the website labels Mar 30, 2023
RhysSullivan
RhysSullivan requested changes Mar 31, 2023
View reviewed changes

@RhysSullivan RhysSullivan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, listed a few requested changes

Comment thread apps/docs/src/pages/_app.tsx
Comment thread packages/ui/src/components/pages/MessageResultPage.tsx Outdated
Comment thread packages/ui/src/components/primitives/Message.tsx Outdated
Comment thread packages/ui/src/components/primitives/Message.tsx Outdated
Comment thread packages/ui/src/components/primitives/Message.tsx Outdated
Comment thread packages/ui/src/components/primitives/Message.tsx
Comment thread packages/ui/src/components/primitives/Message.tsx
Comment thread packages/ui/src/components/primitives/Message.tsx Outdated
Comment thread packages/ui/src/components/primitives/Message.tsx Outdated
Comment thread packages/ui/src/components/primitives/Message.tsx Outdated
@RhysSullivan

RhysSullivan commented Apr 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Extra tasks:

  • For now, only display attachments with .png and .jpg (or handle other types better, atm they 404)
  • Only show Discord icon on hover on desktop
  • On the message result page, only show the discord icon on the first message
  • Add a trackEvent to open in discord clicked, track the server info, channel info, thread info

@RhysSullivan
RhysSullivan marked this pull request as ready for review April 8, 2023 18:38
@codecov

codecov Bot commented Apr 8, 2023

Copy link
Copy Markdown

Codecov Report

Merging #313 (6179c33) into main (515d909) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   68.05%   68.05%           
=======================================
  Files          66       66           
  Lines        2094     2094           
  Branches      535      535           
=======================================
  Hits         1425     1425           
  Misses        596      596           
  Partials       73       73

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RhysSullivan
RhysSullivan merged commit 1f892fe into AnswerOverflow:main Apr 8, 2023
@JoltCode
JoltCode deleted the message-feature-update branch April 10, 2023 08:42
RhysSullivan pushed a commit that referenced this pull request Dec 20, 2025
@JoltCode
(feat): enhance message display (#313)
596ef09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RhysSullivan RhysSullivan RhysSullivan requested changes

Assignees

No one assigned

Labels

⚛ component Issue relates to a react component 🖥️website Relates to the website

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Finish Message Component

2 participants

@JoltCode @RhysSullivan