Implement nontrapping-f2i proposal - #1651
Merged
Merged
Conversation
Member
|
Btw binaryen has special suturation mode which can help for now: |
Member
Author
|
Trying out trapMode, it seems this also legalizes division by zero etc. Not sure if we want that as well? |
Member
Hmm, in this case better avoid this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the meanwhile finished Non-trapping float-to-int Conversion Proposal, suggesting to make it the default behavior over the respective trapping instructions. Reasoning is that trapping can lead to all sorts of breakage with the current runtime, so relying on that would be dangerous.
Keeps the feature behind a flag for now because Safari doesn't yet support it. A follow-up PR could be to explicitly opt-in to trapping operations if so desired, by using a new
checked(...)builtin.