Skip to content

fix: ignore this - #2834

Merged
CountBleck merged 1 commit into
AssemblyScript:mainfrom
CountBleck:empty
Apr 3, 2024
Merged

fix: ignore this#2834
CountBleck merged 1 commit into
AssemblyScript:mainfrom
CountBleck:empty

Conversation

@CountBleck

Copy link
Copy Markdown
Member

This is a dummy commit to create a new release.

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

This is a dummy commit to create a new release.
@CountBleck
CountBleck merged commit b640ff2 into AssemblyScript:main Apr 3, 2024
@CountBleck
CountBleck deleted the empty branch April 3, 2024 03:19
@HerrCai0907

Copy link
Copy Markdown
Member

Do you know why our release pipeline does not work?

@HerrCai0907

Copy link
Copy Markdown
Member

I found the reason, aspublish requires breaking / feat / fix prefix to identifier the version upgrade. Maybe we need to create an action and check the PR title to avoid this weird empty PR. WDYT?

@CountBleck

Copy link
Copy Markdown
Member Author

@HerrCai0907 That would be nice, but if a PR only has one commit, the default commit title in the merge commit is based off of that commit's title, not the PR title (see #2826).

@HerrCai0907

Copy link
Copy Markdown
Member

@HerrCai0907 That would be nice, but if a PR only has one commit, the default commit title in the merge commit is based off of that commit's title, not the PR title (see #2826).

Yes. But we can switch the merge strategy in configuration page. I am not sure who has the access to setup it. Maybe it needs @dcodeIO or @MaxGraey

@CountBleck

Copy link
Copy Markdown
Member Author

@HerrCai0907 that doesn't sound ideal...

@HerrCai0907

Copy link
Copy Markdown
Member

Configuration like this:
image

Why is it not ideal?

@dcodeIO

dcodeIO commented Apr 4, 2024

Copy link
Copy Markdown
Member

Changed the setting to "Pull request title" as suggested

@CountBleck

CountBleck commented Apr 4, 2024

Copy link
Copy Markdown
Member Author

Why is it not ideal?

@HerrCai0907 Oh I misunderstood (I thought you meant switching away from squash merging). That's perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants