Repository navigation
Hybrid linking: plain words for the new results and the Link confirmation - #228
Merged
Merged
Conversation
…tion The hosted side now asks people to confirm a GitHub link on a page that names the install, and refuses a link for three new reasons. The dashboard and the docs install guide say each one in a sentence with what to do next: no_write_access (the person can push to nothing in that installation), declined (they chose Cancel) and install_off (the install isn't verified and active). Both places that send people to GitHub say CoderHelm will show the install's address and ask them to press Link. e2e at 1440 and 390. docs/platform.lock.json moves to the platform commit with the hybrid threat model, so the docs site publishes it.
The hybrid GitHub test read page.url() after the click, when the browser could already be on its way to github.com (origin null): it failed in CI on timing alone.
nambok
force-pushed
the
fix/hybrid-link-outcomes
branch
from
October 26, 2026 20:09
e528f28 to
c30f829
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since CoderHelm/coderhelm-platform#309, linking CoderHelm's GitHub App to a hybrid install ends on a hosted confirmation page that names the install, and it can be refused for three new reasons. This PR gives the dashboard and the docs install guide plain words for those results, mentions the Link step wherever people are sent to GitHub, and points the docs site at the platform commit with the hybrid threat model.
Changes
dashboard/src/lib/hybrid.tsanddocs/lib/install/core.ts: one sentence and the next step forno_write_access(the GitHub account can push to nothing in that installation),declined(they chose Cancel on the confirmation page) andinstall_off(CoderHelm doesn't see the install as verified and active).dashboard/src/components/hybrid-section.tsxanddocs/components/install/wizard.tsx: the Install on GitHub step says CoderHelm will show which install it is about to link, to check the address and press Link (the dashboard also says tokens reach only repositories the person can push to).docs/platform.lock.json: 22548c6 to 4fb3dc7 (platform #309), so docs.coderhelm.com publishes the hybrid threat model in Security model and the corrected Hybrid page.dashboard/e2e/hybrid.spec.tsanddocs/e2e/install.spec.tscheck each title and next step, the Link wording, and that nothing scrolls sideways.Verification
npm run lint,npm run typecheck,npm run build,playwright test e2e/hybrid.spec.ts(29 passed).test:unit,build,typecheck,check:links,check:outputwith the new lock, and the full Playwright suite on a fresh server (82 passed). The built Security model page has the hybrid threat model section.