Repository navigation
Hybrid: Other apps on by default in Settings and the install guide - #306
Merged
Merged
Conversation
The install guide offers CoderHelm's Notion, Confluence and Google Drive apps next to GitHub and Jira under What CoderHelm sets up for you, all on, each with the line Settings shows for what passes through CoderHelm. The choices, Jira included, are sent as apps when the install registers. Settings, System, Hybrid, Other apps saves one tool at a time (apps), so a tool CoderHelm doesn't offer yet is never recorded as the install's own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every tool under Other apps now defaults to "Use Coderhelm's app" on a self-hosted install. The install guide offers the same choices under What CoderHelm sets up for you, all on by default, and applies them when the install registers. Pairs with CoderHelm/coderhelm-platform#455, which sets the default on the install side and keeps explicit "my own app" choices.
Changes
docs/lib/install/core.ts,docs/components/install/wizard.tsx):appswith every tool's choice, Jira included (coderhelmorown). A tool kept on also counts as a reason to register.dashboard/):apps: {id: choice}) instead of the whole list, so a tool CoderHelm doesn't offer yet is never saved as the install's own.HybridSettingsPatch.appsadded.Verification
npm run lint,tsc --noEmit,npm run build, and Playwrighthybrid.spec.ts+selfhost-links.spec.ts: 40 passed. New test: a new install shows Coderhelm's app selected for every tool, and showing it saves nothing. The choice tests now expect per-toolappspatches.test:unit(108),build,typecheck,check:links,check:output, and the full Playwright suite: 166 passed, 6 skipped. New tests: the toggles are on by default with their note and Fully private turns them off; the choices (one turned off) reach the install's settings call asapps; the register flow sends all four ascoderhelmby default. The "Hour" and "Day" selectors in one test are now exact, because "within the hour" in the new notes also matched.eslinton the touched files.