Skip to content

Forgot password says what happened and who sends it; People shows who hasn't signed in here - #311

Merged
nambok merged 2 commits into
mainfrom
forgot-password-setup
Nov 4, 2026
Merged

nambok merged 2 commits into
mainfrom
forgot-password-setup

Conversation

@nambok

@nambok nambok commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

This is the dashboard half of CoderHelm/coderhelm-platform#464.

  • The sign-in page's Forgot password now shows what happened for the email. It names who sends the email, so a person can ask IT to allow that address.
  • Settings, Members and roles no longer makes someone copied from the previous CoderHelm look active on this install. Admins can send set-up emails from the row, or to everyone at once.

Changes

  • Forgot password (self-hosted):
    • The page shows the server's message for each case:
      • a reset code was sent: the page moves to the code entry
      • "You don't have an account here yet. We sent you a set-up link instead."
      • an invite to use
      • "There's no account for on this CoderHelm. Ask an admin to add you.", shown as an error
    • A sender line comes from GET /auth/methods senders, for example: "The reset code comes from no-reply@verificationemail.com (Amazon Cognito, which signs people in here)." or "The set-up link comes from ." It asks the person to check spam, quarantine, or ask IT. When the server sends no senders, the line is hidden.
    • Hosted keeps its single message.
  • Members and roles:
    • A person with no account here now shows Hasn't signed in here yet as their main status, in place of "Active N days ago".
    • Their old activity time, if any, reads "Last active on the previous Coderhelm, 5 days ago".
    • When they have a linked GitHub account and /auth/methods says GitHub works, the row says "Can sign in with GitHub (login)".
    • Send set-up email is a button on the row, and it stays in the menu.
    • The page lead adds "N haven't signed in here yet".
    • A banner reads "N people haven't set up an account here yet", with Send set-up emails to all. Only admins see the button; others are told to ask an admin. A toast reports how many were sent and how many were skipped because they got one in the last hour.
  • teamApi.setupEmailsAll, SignInMethods.senders, ForgotStatus.

Verification

  • npm run lint, npm run typecheck, and npm run build (static export) pass.
  • E2E_STATIC=1 npx playwright test e2e/team.spec.ts e2e/sign-in-methods.spec.ts --project=chromium: 36 passed. The new tests cover:
    • a reset code shows Cognito's sender
    • a set-up link shows the install's sender and no code box
    • no account shows the message and no sender line
    • with an SES sender, that address is shown and not Cognito's
    • a copied-over row shows "Hasn't signed in here yet" with no "Active", plus the previous-activity label, the GitHub line and the row button
    • no GitHub line when GitHub sign-in is off
    • the banner count and send to all, skipping the last hour
    • no send button for a member
  • The screenshot checks find no sideways scroll at 1280 or 375 px.

…who hasn't signed in here

Forgot password shows the install's answer for that email (a reset code,
a set-up link instead, an invite to use, or no account here) and names the
sender to look for, so a person can ask IT to allow it.

Members and roles: someone copied from the previous CoderHelm shows
"Hasn't signed in here yet" instead of their old activity time, with a
Send set-up email button on the row and "Can sign in with GitHub" when it
works. A banner counts them and sends set-up emails to all.
@nambok
nambok merged commit c599a92 into main Nov 4, 2026
18 of 20 checks passed
@nambok
nambok deleted the forgot-password-setup branch November 4, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant