Repository navigation
Admin teams: runs and PRs reviewed, in all and this month - #315
Merged
Merged
Conversation
…d count PRs reviewed Each organisation and team line now reads "412 runs in all, 103 this month" and "37 PRs reviewed in all, 9 this month". Before, the organisation line gave runs and reviews with no period, and the review number was a count of review jobs that never reached the page (always 0). The platform now counts each pull request the reviewer posted a review on once (in all, and once per month), the same rule the weekly email uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The admin Teams page showed "46 runs · 0 reviews" for an organisation with many reviewed pull requests, and 0 reviews for every organisation; the organisation line also gave no period for either number. The numbers now come from counts the platform adds once per run and once per reviewed pull request (CoderHelm/coderhelm-platform, same branch name), and every line says which number is which.
Changes
activity()insrc/app/admin/page.tsx).reviews_total,reviews_month);src/lib/api.tsdocuments what they count.admin.spec.tschecks both labels.Verification
npm run lint,npm run typecheck,npm run check:openapi,npm run build: pass.admin,plugins,audit-insights,emails,support,support-access,health: 96 passed;no-sideways-scroll,no-mid-word-breaks,readable-text,dialogs,shell-menu: 292 passed.