Repository navigation
Docs: the install guide counts anonymous page views with Google Analytics - #307
Merged
Merged
Conversation
…tics The hybrid trust model and setup checks pages say what the guide page sends to Google Analytics (origin and path, step names, link hosts) and that nothing typed, including the name checked, and nothing about the install is sent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paired with CoderHelm/coderhelm#224, which adds Google Analytics to docs.coderhelm.com, including the install guide. The install guide's trust claim is repeated here, so these pages now say what the page sends.
Changes
docs/self-host/hybrid.md, trust model: the install guide page counts anonymous page views with Google Analytics (origin and path, step names, link hosts). Nothing typed, including the name checked, and nothing about the install goes to Google. The install itself sends nothing to Google Analytics.docs/self-host/setup-checks.md: the same, in one sentence.Verification
docs/platform.lock.jsonin coderhelm, so the lock needs a bump to this PR's merge commit once it merges.