Repository navigation
Installer update: check every model the release calls before deploying - #319
Merged
Merged
Conversation
coderhelm-selfhost update reads the release's models.json only after the signature check passes (and, verified with gh, only with its own build attestation), only when the signed SHA256SUMS lists it and its checksum matches. The install's worker then tests each model the release calls, plus the config's own, through the install's provider. A refused model stops the update before anything deploys, with the fix and the console link. --skip-model-check goes on only when the refused model is one the release doesn't call. A rollback and a checkout skip the check. The update build's role may ask the worker and read the SYSTEM setting so the same check runs there.
nambok
force-pushed
the
fix/cli-update-model-check
branch
from
October 26, 2026 23:42
d66d450 to
3414626
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coderhelm-selfhost update, run from someone's machine, now does the same model check as the updater before it applies a release. It reads the release'smodels.jsononly after the signedSHA256SUMScheck from #310 passes. It then tests each model through the install's provider and stops with the same one-sentence fix and console link.--skip-model-checkpasses only a model the release doesn't call. Follow-up to #318.Changes
installer/lib/release.mjs:releaseModels()runs insidefetchRelease, afterverifySignature.models.jsononly when the signedSHA256SUMSlists it, and only when the file matches its checksum.models.jsonmust also carry its own build attestation.null. This also applies to cached releases, which are checked again.installer/lib/commands.mjs:updaterunsupdateModelCheckafter the release is fetched and verified, and before migration notes, the diff or deploy.<prefix>-workergets amodel_checkdirect invoke with the release's models plus the config's own, using the release's Bedrock ids per prefix. The probe team comes from theSYSTEM/MODELSrecord.--skip-model-checkcan't override it.--skip-model-checkpasses only failures on models the release doesn't call, and records "model check skipped for …" in the result file.--sourcecheckouts and dry runs skip the check.installer/lib/cli.mjs: help for--skip-model-check.infra/lib/updates-stack.ts: the update build runscoderhelm-selfhost update, so its role may now invoke<prefix>-workerand read the settings table, limited to theSYSTEMpartition by a LeadingKeys condition. The same check therefore runs inside the build too.updates.mdandmodel-providers.mddescribe the CLI check and the skip rule.Verification
npm test: 97 pass. The new tests cover:models.jsonis fetched only afterverify-blobpasses, and never when the signature fails.models.jsonneeds its own attestation.--skip-model-check.npm test: 64 pass, including the build role's new worker invoke andSYSTEM-onlyGetItem.python3 -m unittest discover -s lambda/testsandnode --test selfhost/launch/*.test.mjspass. No Rust changes.