Repository navigation
Investigate tickets across the team's repos and ask a person only what they alone can answer - #473
Merged
Merged
Conversation
…t they alone can answer The planner searches the team's other connected repos when a search in the run's repo finds nothing, and reads each consulted repo's instruction files and team instructions on first read. Bug and question plans get a missing-or-wrong-data method: trace the record layer by layer, look up stable ids, read where a field is written, compare change times to the sync cursor. A question to a person must say what was checked and what the answer changes, and is held back when the run could answer it, rests on a field whose writer was never read, or follows conflicting findings (stop rule 5). A plan that stops without a fix names the one next step and what each outcome would mean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the planner investigate tickets about missing or wrong data the way a person would, for every team:
Before this, a ticket filed against a web repository about records missing from the site was investigated only there. The search index builder lives in another repository, so the run never found it. It then asked a question based on a misread field (a date the pipeline copies from another date) and stopped.
Changes
Cross-repo investigation (
passes/cross_repo.rs,plan.rs)repoto its tools, but nothing told it when to.search_codewith norepothat finds nothing in the run's repository searches up to 8 of the team's other connected repositories, read-only. The hits come back labelled by repository.fix_locationalready records a producer asowner/repo:path, counts files opened in other repositories, and plansother_reposteps.Instructions from every consulted repository
Missing or wrong data method (
fix_location::MISSING_DATA_GUIDANCE, bug and question tickets)evidence.layers(layer, where it lives, what it shows, its state). Reports render it as "Layer by layer".Asking a person: the question gate (
stop_rules::screen::asking_rule, stop rule 5)CLARIFICATION_NEEDED:question now carrieschecked:,changes:and, when it rests on a field,written_at:. People see the first two as "Already checked" and "What the answer changes".path:line(in any team repository) or a lookup it made;checked:andchanges:. CoderHelm's own notices (decision) are exempt.unknown, no code) instead of failing.One next step from a person (
FixDecision.next_step)unknownmust name one action, why the run can't take it, and at least two outcomes, each with its meaning. A decision without them is sent back once.PLANNER_VERSIONis bumped so cached plans from the old planner aren't reused.Verification
cargo fmt --all --checkcargo clippy -p common -p worker -p gateway --all-targets -- -D warningscargo test -p common -p worker -p gatewaylayersandnext_stepfields are in the planner's prompt;next_stepgaps, and the report with its layers, step and outcomes;checked,changesandwritten_atparse, render and round-trip, and old stored questions still read.