Skip to content

fix(automation): replace conflicted mention concurrency repair - #824

Closed
seonghobae wants to merge 6 commits into
fix/strix-quality-timeout-fixturesfrom
fix/agent-mention-event-concurrency-replacement
Closed

fix(automation): replace conflicted mention concurrency repair#824
seonghobae wants to merge 6 commits into
fix/strix-quality-timeout-fixturesfrom
fix/agent-mention-event-concurrency-replacement

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Replacement purpose

Rebuild the trusted review-agent mention concurrency repair from the exact current prerequisite branch fix/strix-quality-timeout-fixtures at 9dfb5ee2795b845f709f5f85ba68c8dda5810f43. Predecessor PR #815 is conflicted against the current control plane and must not be force-rewritten or treated as current evidence.

No check, review, approval, comment, or synthetic merge result from #815 transfers to this replacement.

Test-first state

Exact RED head: e8ee2debfd3ec6aada677e0d8f14b4c79fc2d5b6.

This head changes only tests/test_agent_mention_workflow_contract.py. The permanent regression requires the interactive issue-comment route and scheduled organization sweep to stop sharing one workflow-level concurrency group. The inherited prerequisite workflow still has that shared group, so the focused contract is intentionally RED before production repair.

Required bounded repair

  • remove workflow-level concurrency from agent-mention-router.yml;
  • give route-local-agent-mention its own local group with bounded queue: max semantics;
  • give sweep-organization-agent-mentions a distinct group with cancel-in-progress: false;
  • preserve deterministic invocation keys, exact-name artifact ledger, reviewer identities, credential chain, repository allowlist, dispatch payloads, permissions, models, and branch protection;
  • retain the 30-day ledger contract and update doctoring/CHANGELOG only after production is GREEN.

Stack boundary

This PR is intentionally stacked on #823. After #823 reaches protected main, retarget this replacement to main, verify the effective diff remains only the mention-concurrency slice, and rerun every exact-head quality/security/review gate. Keep Draft until then.

Refs #814 and supersedes #815 only after protected integration.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f5f53bc9-4f96-42e0-a4b5-ea3a1389663a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Superseded by direct-protected-main replacement #825. #824 was intentionally stacked on #823 and therefore could not produce direct-main exact-head workflow evidence while the review-agent router defect itself was blocking reliable reviewer dispatch. #825 reconstructs the same bounded five-file concurrency slice from protected main 1131b1bbafb24e455fc8619cdf316813e8721861 with a fresh fail-first head and no inherited #823 changes. Closing this duplicate avoids competing branch writers. No checks, reviews, approvals, comments, or merge evidence from #824 transfer to #825; the branch and history remain preserved for audit.

@seonghobae seonghobae closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant