Skip to content

If only a custom Ressource provider is provided old version failed --> now fixed - #224

Merged
Entenwilli merged 7 commits into
mainfrom
BugFix-CustomRessourceProvider
Nov 27, 2024
Merged

If only a custom Ressource provider is provided old version failed --> now fixed#224
Entenwilli merged 7 commits into
mainfrom
BugFix-CustomRessourceProvider

Conversation

@BenjaminArp

Copy link
Copy Markdown
Contributor

No description provided.

01Parzival10
01Parzival10 previously approved these changes Nov 27, 2024

@01Parzival10 01Parzival10 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@01Parzival10

Copy link
Copy Markdown
Contributor

Wait before merging. I'm currently writing a test or two for that

01Parzival10
01Parzival10 previously approved these changes Nov 27, 2024

@01Parzival10 01Parzival10 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged after @Entenwilli had a look at it

@Entenwilli Entenwilli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one smaller comment about the SuppressWarnings annotations

@Entenwilli
Entenwilli self-requested a review November 27, 2024 15:19

@Entenwilli Entenwilli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@Entenwilli
Entenwilli merged commit 3d20c0f into main Nov 27, 2024
@Entenwilli
Entenwilli deleted the BugFix-CustomRessourceProvider branch November 27, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants