Skip to content

Add documentation for installation in Eclipse and IntelliJ - #230

Closed
Entenwilli wants to merge 4 commits into
mainfrom
setup-documentation
Closed

Add documentation for installation in Eclipse and IntelliJ#230
Entenwilli wants to merge 4 commits into
mainfrom
setup-documentation

Conversation

@Entenwilli

Copy link
Copy Markdown
Member

This PR adds instructions in the README.md to set up the data flow analysis with both eclipse and IntelliJ

@Entenwilli Entenwilli added enhancement New feature or request core Related to the core DFD/PCM data flow analysis support Related to supporting projects which are neither core analysis or meta model bundels labels Dec 8, 2024
@Entenwilli Entenwilli added this to the 4.0.0 milestone Dec 8, 2024
@Entenwilli Entenwilli self-assigned this Dec 8, 2024
@Entenwilli
Entenwilli marked this pull request as draft December 8, 2024 16:56
@Entenwilli

Entenwilli commented Dec 8, 2024

Copy link
Copy Markdown
Member Author

@sebinside @uuqjz @Nicolas-Boltz @01Parzival10 @BenjaminArp Some feedback on this would be nice. Should I add some pictures for each/some steps?

@01Parzival10

01Parzival10 commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

I managed to run the analysis by referencing it from a new Project.
However, I can seem to get existing projects to run. Eclipse Intellij does not recognize the main/test classes

@Entenwilli

Copy link
Copy Markdown
Member Author

I managed to run the analysis by referencing it from a new Project. However, I can seem to get existing projects to run. Eclipse does not recognize the main/test classes

Do you mean IntelliJ, or really Eclipse?

@01Parzival10

Copy link
Copy Markdown
Contributor

I managed to run the analysis by referencing it from a new Project. However, I can seem to get existing projects to run. Eclipse does not recognize the main/test classes

Do you mean IntelliJ, or really Eclipse?

IntelliJ

@Entenwilli

Copy link
Copy Markdown
Member Author

I've updated the guide by detailing a few more steps and images. This should hopefully fix it.
Nonetheless, this is valuable feedback, as we should expect users to use the DFA from these instructions

@Entenwilli

Copy link
Copy Markdown
Member Author

@01Parzival10

@Entenwilli
Entenwilli marked this pull request as ready for review December 9, 2024 16:13

@sebinside sebinside left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to follow the IntelliJ guide but without success. Here are a couple of comments / hints:

  • The guide lack an overview that tells less experienced developers (or developers that don't know IntelliJ at all), which steps are required in general
  • Many steps lack details are us ambiguous language, e.g., step 2 with "our data flow analysis product" (which product, extracted zip?), "well known location" (which location, does it matter, or just that I know where I put it)
  • The pictures help a lot, but are sometimes not enough, e.g., step 5 where you expect the "+" button to be clicked. Also other steps sometimes lack precise information where to look or what to click
  • I was not able to understand neither follow step 8 - 11
  • The guide ends without showing a final results or showing how to, e.g., execute a test
  • Also, you should at least mention for which IntelliJ version you build this guide as things might/will change

TL;DR: In its current version, the guide requires a lot of detail knowledge that it should explain to non-experts in the first place :)

@sebinside sebinside modified the milestones: 4.0.0, 5.0.0 Jan 7, 2025
@Entenwilli

Entenwilli commented Jan 13, 2025

Copy link
Copy Markdown
Member Author

I've rephrased the installation instructions. Some tasks are still open:

  • Mention IntelliJ verison
  • Add instructions for missing newer junit version (Remove automatically added dependency under external libraries)
  • Shorten command line troubleshooting tip
  • Make sure Java Project JDK Level is set

For which step should I insert more images?

@sebinside
sebinside self-requested a review January 14, 2025 12:09
@BenjaminArp

Copy link
Copy Markdown
Contributor

Setup IntelliJ with nightly and current IntelliJ version in 20 minutes without any issues.

@Entenwilli

Copy link
Copy Markdown
Member Author

Superseeded by #292

@Entenwilli Entenwilli closed this Jul 1, 2025
@Entenwilli
Entenwilli deleted the setup-documentation branch October 15, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Related to the core DFD/PCM data flow analysis enhancement New feature or request support Related to supporting projects which are neither core analysis or meta model bundels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants