Avoid negative integer overflow when iccOffset > chunkLength#795
Merged
piponazo merged 1 commit intoMay 5, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.27-maintenance #795 +/- ##
====================================================
+ Coverage 62.67% 62.67% +<.01%
====================================================
Files 156 156
Lines 21523 21524 +1
====================================================
+ Hits 13490 13491 +1
Misses 8033 8033
Continue to review full report at Codecov.
|
D4N
previously requested changes
Apr 25, 2019
D4N
left a comment
Member
There was a problem hiding this comment.
Looks good, I've added some minor suggestions and one info that needn't be addressed now.
kevinbackhouse
force-pushed
the
bugfix_790_PngImage_readMetadata
branch
2 times, most recently
from
April 25, 2019 20:32
6710899 to
cffac6e
Compare
kevinbackhouse
force-pushed
the
bugfix_790_PngImage_readMetadata
branch
from
May 2, 2019 09:18
b0b81ab to
709830d
Compare
piponazo
self-requested a review
May 5, 2019 05:18
Member
|
Lgtm, please merge this! (Cannot approve right now) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #790.