Skip to content

Avoid null pointer exception due to NULL return value from strchr#815

Merged
piponazo merged 1 commit into
Exiv2:0.27-maintenancefrom
kevinbackhouse:bugfix_793_nullpointer_http
May 4, 2019
Merged

Avoid null pointer exception due to NULL return value from strchr#815
piponazo merged 1 commit into
Exiv2:0.27-maintenancefrom
kevinbackhouse:bugfix_793_nullpointer_http

Conversation

@kevinbackhouse

Copy link
Copy Markdown
Collaborator

This fixes #793.

@clanmills clanmills added this to the v0.27.2 milestone Apr 30, 2019
@codecov

codecov Bot commented Apr 30, 2019

Copy link
Copy Markdown

Codecov Report

Merging #815 into 0.27-maintenance will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           0.27-maintenance     #815      +/-   ##
====================================================
- Coverage             62.67%   62.65%   -0.03%     
====================================================
  Files                   156      156              
  Lines                 21523    21530       +7     
====================================================
  Hits                  13490    13490              
- Misses                 8033     8040       +7
Impacted Files Coverage Δ
src/http.cpp 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79af9f...c1bee73. Read the comment docs.

@D4N D4N added the to-master label May 1, 2019
Comment thread src/http.cpp

@D4N D4N left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase your changes on 0.27-maintenance and then I'll approve them.

@kevinbackhouse
kevinbackhouse force-pushed the bugfix_793_nullpointer_http branch from e76227f to c1bee73 Compare May 2, 2019 09:09
@kevinbackhouse

Copy link
Copy Markdown
Collaborator Author

I rebased it onto 0.27-maintenance.

@D4N
D4N self-requested a review May 2, 2019 09:13

@D4N D4N left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@piponazo
piponazo merged commit ae20c30 into Exiv2:0.27-maintenance May 4, 2019
@kevinbackhouse
kevinbackhouse deleted the bugfix_793_nullpointer_http branch September 18, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants