Repository navigation
ci(release): exempt the alpha promotion PR; no exemptions for forks - #380
Merged
Merged
Conversation
The alpha -> main promotion carries alpha's shipped changes with no top-level changeset (they were consumed into .changeset/pre/), so the check would fail it. And head-ref exemptions matched the branch name alone, so a fork PR from a contributor's own main skipped the check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Visual regression report✅ No visual changes across 3288 screenshot(s). 📦 Open the full visual report (artifact Baseline from this run · commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two gaps in
scripts/release/changeset-check.mjs. Both were found while porting this design to FiestaBoard (Fiestaboard/FiestaBoard#2430), where they are already fixed:docs/releasing.mdopens a PR fromalphaintomain. It carries alpha's shipped changes, but those changesets were consumed by the prereleases into.changeset/pre/, so there is no top-level changeset. Head refalphais now exempt, next tomain(syncs) andchangeset-release/*.github.head_ref, which is only the branch name, so a contributor's fork PR from theirmainwas waved through. Exemptions now apply only whenhead.repo.full_nameis this repository;ci.ymlpassesHEAD_REPO.CI and release scripts only, so no changeset is needed.
Verification
node --test scripts/release/tests/*.test.mjs: 33 pass, including new tests for the promotion exemption and for fork PRs onmain,alphaandchangeset-release/main.🤖 Generated with Claude Code