fix: add POSIX headers for musl compatibility - #1397
Open
bakshansky wants to merge 3 commits into
Open
Conversation
archigup
approved these changes
Mar 18, 2026
Member
|
Adding the libslirp dependency to the README would be useful. If its in the deps, it can be translated to other distros. Not sure if another setup script is needed. |
Include sys/time.h and sys/select.h where timeval, fd_set and select are used. This is required for compilation on Alpine Linux (musl libc). Refs FreeRTOS#1387 Signed-off-by: Roman Bakshansky <bakshansky@protonmail.com>
cookpate
force-pushed
the
add-alpine-support-1387
branch
from
April 28, 2026 21:17
411fbea to
e4a201c
Compare
cookpate
previously approved these changes
Apr 28, 2026
archigup
previously approved these changes
Jun 12, 2026
archigup
enabled auto-merge (squash)
June 12, 2026 07:06
auto-merge was automatically disabled
June 12, 2026 07:53
Head branch was pushed to by a user without write access
Author
|
@archigup, I've added the libslirp documentation as suggested; sorry for disabling auto-merge |
archigup
approved these changes
Jun 12, 2026
Member
|
No problem, thanks for the PR! |
kstribrnAmzn
approved these changes
Jun 15, 2026
cookpate
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've fixed the build error on Alpine Linux by adding missing POSIX headers (
<sys/time.h>and<sys/select.h>) to the files that usetimeval,fd_set, andselect. Now both Posix demos compile successfully on musl.However, I'm not sure about the remaining tasks mentioned in the issue:
libslirp-devand other dependencies on Alpine?setup-alpine.sh) or extend the existing one?I'd appreciate guidance from maintainers. I'm willing to do the work, but I need directions.
Test Steps
Related Issue
Refs #1387