Endpoints Auth Between Services#1330
Merged
daniel-sanche merged 15 commits intoFeb 8, 2019
Merged
Conversation
kurtisvg
suggested changes
Feb 8, 2019
kurtisvg
left a comment
Contributor
There was a problem hiding this comment.
There are also likely several style violations that checkstyle will check when the parent pom is added.
19765e9 to
510d311
Compare
Member
Author
|
@kurtisvg I addressed your comments, let me know if there's anything else |
Contributor
|
@dansanche Just needs a test for the two snippets, then LGTM |
Member
Author
|
The issue with testing these is that it requires an endpoints backed to be deployed for it to work as intended. If you think it's necessary, I could test the jwt creation function in isolation, but it feels like that would be more a test of the jwt/cyptography libraries I'm using rather than the sample itself |
kurtisvg
approved these changes
Feb 8, 2019
Contributor
|
No, that seems like a reasonable explanation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding java samples for endpoints auth between services
related to b/109951097 and cl/228405078