Update java8 tests to run against java11#2029
Merged
Merged
Conversation
Contributor
|
I see the following: |
Contributor
|
Looks like you've found a flaw in our test script - it's not running in either project because a property is being used to pass in the java version. We should probably add a specific check for if the $JAVA_POM isn't something we expect and make sure that we log that it's invalid and either fail or run the test anyway. |
Contributor
Author
|
Can I hard code the values we expect? |
Contributor
Yeah that seems reasonable. |
Contributor
Author
|
I've removed the sample. The one I chose is broken so I added an issue #2030 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample edits to force sample run.