fix: 安装整合包部分任务未正确归类#5922
Merged
Merged
Conversation
Contributor
CiiLu
commented
Apr 6, 2026
Member
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates ModpackHelper.java to replace raw string stage hints with structured Task.StagesHint objects and refines the class imports. A review comment suggests extracting the repeated StagesHint instances into constants to reduce redundancy and improve maintainability.
| return new ServerModpackRemoteInstallTask(profile.getDependency(), manifest, name) | ||
| .whenComplete(Schedulers.defaultScheduler(), success, failure) | ||
| .withStagesHints("hmcl.modpack", "hmcl.modpack.download"); | ||
| .withStagesHints(new Task.StagesHint("hmcl.modpack"), new Task.StagesHint("hmcl.modpack.download", List.of("hmcl.install.assets", "hmcl.install.libraries"))); |
Contributor
There was a problem hiding this comment.
这里的任务阶段提示（StagesHint）在文件中重复出现了多次（共 5 处，分别在第 173、217、222、226 和 234 行）。建议将这些重复的提示提取为类级别的私有常量（例如 MODPACK_STAGE 和 DOWNLOAD_STAGE），以提高代码的可维护性，减少冗余，并避免未来修改时出现拼写不一致的问题。
Glavo
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.