Fix optional cardinality handling for Attribute and PartOf facets by louistrue · Pull Request #7645 · IfcOpenShell/IfcOpenShell

louistrue · 2026-02-07T09:17:29Z

Summary

Attribute facet: add early return for optional cardinality when value is null/empty (the existing check only covered schema-level absence)
PartOf facet: add optional cardinality checks at all 6 missing-relationship paths

All 23 existing facet tests pass
All 15 existing IDS tests pass
New unit tests for optional+null, optional+empty, optional+wrong-value (Attribute)
New unit test for optional+no-relationship (PartOf)
New integration test: required Name + optional Description with empty Description passes

Fix optional cardinality handling for Attribute and PartOf facets - F…

e30748a

…ixes IfcOpenShell#6323

Moult marked this pull request as draft February 16, 2026 04:23

Moult mentioned this pull request Feb 16, 2026

Facet optionality is not completely supported #6323

Closed