Add material associations to IFC4 Demo Library window/door types#7653
Open
jaliste wants to merge 3 commits intoIfcOpenShell:v0.8.0from
Open
Add material associations to IFC4 Demo Library window/door types#7653jaliste wants to merge 3 commits intoIfcOpenShell:v0.8.0from
jaliste wants to merge 3 commits intoIfcOpenShell:v0.8.0from
Conversation
Contributor
|
G'day! Thanks for the PR, a few comments:
|
d6f0034 to
518fdc2
Compare
Contributor
Author
|
Thanks, so I try now to do it in the genertae_demo_library.py and I added a map to translate from "Frame" to "Framing"... but maybe it's better to change the original names in the materials in the .blend file to match the IFC naming "Framing" "Glazing"? |
Contributor
|
Thanks, this is better! I think you need to add the shape aspects first though: https://docs.ifcopenshell.org/autoapi/ifcopenshell/api/geometry/index.html#ifcopenshell.api.geometry.add_shape_aspect |
Add support for IfcMaterialConstituentSet and IfcShapeAspect to window and door types in the demo library generator script. This enables proper material-to-geometry association for parametric windows/doors. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Regenerated IFC2X3, IFC4, and IFC4X3 demo library files with material constituent sets and shape aspects for window and door types. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When converting a window or door to parametric via AddWindow/AddDoor, load material constituents from the element's type. This ensures the materials display correctly from the start instead of appearing black. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
518fdc2 to
50ddd25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Window and door types in the demo library had IfcSurfaceStyles for
appearance but no IfcMaterial associations. This caused materials
to be lost when converting to parametric elements.
Added:
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com