Fix #7712: Fix text annotation alignment not saved on edit#7713
Open
theoryshaw wants to merge 2 commits intov0.8.0from
Open
Fix #7712: Fix text annotation alignment not saved on edit#7713theoryshaw wants to merge 2 commits intov0.8.0from
theoryshaw wants to merge 2 commits intov0.8.0from
Conversation
edit_text was missing a call to edit_text_alignment, so align_vertical/align_horizontal prop changes were never exported to IFC. Additionally, edit_text_alignment was called before edit_text_literals, which deletes and recreates the IFC literal entities — discarding the alignment change immediately. Moved the call to after edit_text_literals. EditText operator was also being replayed by Blender's undo/register stack with stale prop values, overwriting the correct alignment. Guarded _execute with is_editing to make replayed calls no-ops. Also fixed a ValueError in is_camera_moved where np_frombuffer_legacy returns a flat (9,) array but the rotation dot product requires (3,3). Fixed with reshape. Generated with the assistance of an AI coding tool.
When enabling text editing, align_vertical and align_horizontal were not populated from the existing IFC BoxAlignment value, causing them to revert to their Blender property defaults. Generated with the assistance of an AI coding tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edit_text was missing a call to edit_text_alignment, so align_vertical/align_horizontal prop changes were never exported to IFC.
Additionally, edit_text_alignment was called before edit_text_literals, which deletes and recreates the IFC literal entities — discarding the alignment change immediately. Moved the call to after edit_text_literals.
EditText operator was also being replayed by Blender's undo/register stack with stale prop values, overwriting the correct alignment. Guarded _execute with is_editing to make replayed calls no-ops.
Also fixed a ValueError in is_camera_moved where
np_frombuffer_legacy returns a flat (9,) array but the rotation dot product requires (3,3). Fixed with reshape.
Generated with the assistance of an AI coding tool.