Skip to content

Fix #7712: Fix text annotation alignment not saved on edit#7713

Open
theoryshaw wants to merge 2 commits intov0.8.0from
text_alignment
Open

Fix #7712: Fix text annotation alignment not saved on edit#7713
theoryshaw wants to merge 2 commits intov0.8.0from
text_alignment

Conversation

@theoryshaw
Copy link
Member

edit_text was missing a call to edit_text_alignment, so align_vertical/align_horizontal prop changes were never exported to IFC.

Additionally, edit_text_alignment was called before edit_text_literals, which deletes and recreates the IFC literal entities — discarding the alignment change immediately. Moved the call to after edit_text_literals.

EditText operator was also being replayed by Blender's undo/register stack with stale prop values, overwriting the correct alignment. Guarded _execute with is_editing to make replayed calls no-ops.

Also fixed a ValueError in is_camera_moved where
np_frombuffer_legacy returns a flat (9,) array but the rotation dot product requires (3,3). Fixed with reshape.

Generated with the assistance of an AI coding tool.

edit_text was missing a call to edit_text_alignment,
so align_vertical/align_horizontal prop changes were
never exported to IFC.

Additionally, edit_text_alignment was called before
edit_text_literals, which deletes and recreates the
IFC literal entities — discarding the alignment change
immediately. Moved the call to after edit_text_literals.

EditText operator was also being replayed by Blender's
undo/register stack with stale prop values, overwriting
the correct alignment. Guarded _execute with is_editing
to make replayed calls no-ops.

Also fixed a ValueError in is_camera_moved where
np_frombuffer_legacy returns a flat (9,) array but the
rotation dot product requires (3,3). Fixed with reshape.

Generated with the assistance of an AI coding tool.
When enabling text editing, align_vertical and
align_horizontal were not populated from the existing
IFC BoxAlignment value, causing them to revert to
their Blender property defaults.

Generated with the assistance of an AI coding tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant