Fix settings hashtable input#491
Merged
Merged
Conversation
Hashtable keys were compared in case-sensitive manner to lower case valid keys while adding values to the lists of severity, rule inclusion and rule exclusion. This commit also remove the relevant code duplication in ParseProfileHashtable and ParseProfileString while adding the values to the respective lists.
Member
|
Engine/ScriptAnalyzer.cs, line 219 [r1] (raw file): Comments from Reviewable |
Member
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
* Changes the name to AddProfileItem * Adds input argument validation
Member
|
Reviewed 1 of 1 files at r2. Comments from Reviewable |
Member
|
Comments from Reviewable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hashtable keys were compared in case-sensitive manner to lower case valid
keys while adding values to the lists of severity, rule inclusion and rule
exclusion.
This commit also remove the relevant code duplication in ParseProfileHashtable
and ParseProfileString while adding the values to the respective lists.
Fixes #475
This change is