Fix Progress Preference variable in adv functions#24591
Merged
daxian-dbw merged 7 commits intoPowerShell:masterfrom Jun 3, 2025
Merged
Fix Progress Preference variable in adv functions#24591daxian-dbw merged 7 commits intoPowerShell:masterfrom
daxian-dbw merged 7 commits intoPowerShell:masterfrom
Conversation
Contributor
Author
|
@iSazonov -- Resubmitted, included changes to test names as requested |
Collaborator
|
Request for Engine-Performance group. The PR updates code with performance optimizations. Please make conclusion about performance risks in some (maybe edge) scenarios. |
|
When should we expect this to be merged? It’s been an open PR for 4 months now… |
Member
|
@cmkb3 Sorry it took so long to review this PR! The fix looks good, but I pushed a commit for 2 minor changes:
|
iSazonov
approved these changes
Jun 3, 2025
Collaborator
|
Thanks for reviewing and merging this bugfix. Hopefully we can have it backported as well! |
5 tasks
5 tasks
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
…werShell#24591) Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
9 tasks
daxian-dbw
added a commit
to daxian-dbw/PowerShell
that referenced
this pull request
Feb 12, 2026
…werShell#24591) Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Feb 20, 2026
…werShell#24591) Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
!Resubmission
This fixes an array out of bounds/type error that occurs when using the -ProgressAction common parameter in advanced functions. The reference variable and variable type arrays are missing the ProgressPreference entry which causes various engine errors including index out of bounds and invalid typecast from index collision.
PR Context
Fixes: #21074 'The -ProgressAction parameter doesn't work (PowerShell 7.4.1 only)'
Fixes: #20657 'The new -ProgressAction common parameter breaks calls to advanced scripts and functions. '
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).