Skip to content

Replace stackallocs with collection expressions#25803

Merged
iSazonov merged 2 commits into
PowerShell:masterfrom
xtqqczze:stackalloc-collection
Oct 17, 2025
Merged

Replace stackallocs with collection expressions#25803
iSazonov merged 2 commits into
PowerShell:masterfrom
xtqqczze:stackalloc-collection

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Jul 31, 2025 •
edited
Loading

This is the same thing that was done in dotnet/runtime#105143.

These will result in using an InlineArray rather than a localloc.

@xtqqczze xtqqczze requested review from a team and jshigetomi as code owners July 31, 2025 11:44
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label Aug 7, 2025
@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Oct 16, 2025

@iSazonov Please approve workflows.

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Oct 17, 2025

/azp run PowerShell-Windows-Packaging-CI, PowerShell-CI-linux-packaging

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Oct 17, 2025

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Review - Needed The PR is being reviewed label Oct 17, 2025
@iSazonov iSazonov enabled auto-merge (squash) October 17, 2025 04:09
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 17, 2025
@iSazonov iSazonov self-assigned this Oct 17, 2025
@iSazonov iSazonov merged commit b4f42a0 into PowerShell:master Oct 17, 2025
34 of 36 checks passed
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

microsoft-github-policy-service Bot commented Oct 17, 2025 •
edited by unfurl-links Bot
Loading

📣 Hey @@xtqqczze, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

SIRMARGIN pushed a commit to SIRMARGIN/PowerShell that referenced this pull request Dec 12, 2025
@xtqqczze @SIRMARGIN
Replace stackallocs with collection expressions (PowerShell#25803)
3d187d9
kilasuit pushed a commit to kilasuit/PowerShell that referenced this pull request Jan 2, 2026
@xtqqczze @kilasuit
Replace stackallocs with collection expressions (PowerShell#25803)
2a1f255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@jshigetomi jshigetomi Awaiting requested review from jshigetomi

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xtqqczze @iSazonov