Refactor IsComputerNameValid character validation#26274
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors the IsComputerNameValid method to modernize character validation by replacing manual ASCII range checks with built-in .NET helpers (char.IsAsciiLetter and char.IsAsciiDigit). The logic is also clarified by using a positive hasNonDigit flag instead of the negated allDigits variable.
Key changes:
- Replaced manual character range comparisons with
char.IsAsciiLetter()andchar.IsAsciiDigit() - Simplified control flow by combining letter and hyphen checks
- Renamed
allDigitstohasNonDigitfor clearer boolean logic
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
iSazonov
reviewed
Oct 22, 2025
iSazonov
reviewed
Oct 27, 2025
iSazonov
reviewed
Oct 27, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
iSazonov
approved these changes
Nov 14, 2025
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
kilasuit
pushed a commit
to kilasuit/PowerShell
that referenced
this pull request
Jan 2, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify and modernize the implementation of
IsComputerNameValidby using built-in char classification helpers instead of manual character range checks.The boolean logic was clarified by replacing
allDigits(with negated return) with ahasNonDigitvariable.Subset of #26270
Contributes to #26275