Skip to content

[release/v7.6] Make the experimental feature PSFeedbackProvider stable #26502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 2 commits into from
Dec 5, 2025
Merged

[release/v7.6] Make the experimental feature PSFeedbackProvider stable #26502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43b32c6
Make the experimental feature `PSFeedbackProvider` stable (#26343)
daxian-dbw Oct 30, 2025
acbcb51
Merge branch 'release/v7.6' into backport/release/v7.6/26343-eda7e4a88
adityapatwardhan Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 1 addition & 46 deletions src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2565,14 +2565,7 @@ internal void Run(bool inputLoopIsNested)
// Evaluate any suggestions
if (previousResponseWasEmpty == false)
{
if (ExperimentalFeature.IsEnabled(ExperimentalFeature.PSFeedbackProvider))
{
EvaluateFeedbacks(ui);
}
else
{
EvaluateSuggestions(ui);
}
EvaluateFeedbacks(ui);
}

// Then output the prompt
Expand Down Expand Up @@ -2896,44 +2889,6 @@ private void EvaluateFeedbacks(ConsoleHostUserInterface ui)
}
}

private void EvaluateSuggestions(ConsoleHostUserInterface ui)
{
// Output any training suggestions
try
{
List<string> suggestions = HostUtilities.GetSuggestion(_parent.Runspace);

if (suggestions.Count > 0)
{
ui.WriteLine();
}

bool first = true;
foreach (string suggestion in suggestions)
{
if (!first)
ui.WriteLine();

ui.WriteLine(suggestion);

first = false;
}
}
catch (TerminateException)
{
// A variable breakpoint may be hit by HostUtilities.GetSuggestion. The debugger throws TerminateExceptions to stop the execution
// of the current statement; we do not want to treat these exceptions as errors.
}
catch (Exception e)
{
// Catch-all OK. This is a third-party call-out.
ui.WriteErrorLine(e.Message);

LocalRunspace localRunspace = (LocalRunspace)_parent.Runspace;
localRunspace.GetExecutionContext.AppendDollarError(e);
}
}

private string EvaluatePrompt()
{
string promptString = _promptExec.ExecuteCommandAndGetResultAsString("prompt", out _);
Expand Down
5 changes: 0 additions & 5 deletions src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

using System.Collections;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.Linq;
Expand All @@ -21,7 +20,6 @@ public class ExperimentalFeature
#region Const Members

internal const string EngineSource = "PSEngine";
internal const string PSFeedbackProvider = "PSFeedbackProvider";
internal const string PSSerializeJSONLongEnumAsNumber = nameof(PSSerializeJSONLongEnumAsNumber);
internal const string PSProfileDSCResource = "PSProfileDSCResource";

Expand Down Expand Up @@ -109,9 +107,6 @@ static ExperimentalFeature()
new ExperimentalFeature(
name: "PSLoadAssemblyFromNativeCode",
description: "Expose an API to allow assembly loading from native code"),
new ExperimentalFeature(
name: PSFeedbackProvider,
description: "Replace the hard-coded suggestion framework with the extensible feedback provider"),
new ExperimentalFeature(
name: PSSerializeJSONLongEnumAsNumber,
description: "Serialize enums based on long or ulong as an numeric value rather than the string representation when using ConvertTo-Json."
Expand Down
Loading
Loading