Fix to use accurate message for validating a string argument is not null and not an empty string#26668
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes argument validation in the CompletionResult constructor by replacing the legacy PowerShell-specific null/empty string validation pattern with the standard .NET ArgumentException.ThrowIfNullOrEmpty method. This simplifies the validation code while introducing a minor breaking change in the exception type thrown from PSArgumentNullException to ArgumentException.
Key Changes
- Replaced manual
string.IsNullOrEmptychecks followed byPSTraceSource.NewArgumentNullExceptioncalls withArgumentException.ThrowIfNullOrEmptycalls - Consolidated validation logic to be more concise (from ~15 lines to 3 lines)
- Maintained the same validation behavior (null or empty strings are rejected)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iSazonov
approved these changes
Jan 8, 2026
SeeminglyScience
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #26620
Use
ArgumentException.ThrowIfNullOrEmptyinstead ofthrow PSTraceSource.NewArgumentNullException(string paramname)for not-null-not-empty argument validation. This simplifies the argument validation.Potential breaking change: the exception throw for invalid argument value becomes
System.ArgumentExceptionfrom the oldSystem.Management.Automation.PSArgumentNullException. I think this falls in bucket 3 (grey area).PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header