Fix a preview detection test for the packaging script#26882
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Feb 23, 2026
Merged
Fix a preview detection test for the packaging script#26882daxian-dbw merged 1 commit intoPowerShell:masterfrom
daxian-dbw merged 1 commit intoPowerShell:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves test coverage for the macOS package identifier detection logic by converting a single test case into a parameterized test that covers both preview and RC versions. The change addresses issue #26673, which was about incorrectly using package name instead of version string for preview detection.
Changes:
- Converted a single test into a parameterized test with test cases for both "preview" and "rc" versions
- Removed redundant test code that verified the incorrect logic pattern
- Maintained the core assertion that version strings correctly identify preview builds
TravisEz13
approved these changes
Feb 23, 2026
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Feb 25, 2026
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix a preview detection test for the packaging script.