Fix ConvertFrom-ClearlyDefinedCoordinates to handle API object coordinates#26893
Open
Fix ConvertFrom-ClearlyDefinedCoordinates to handle API object coordinates#26893
Conversation
… API response Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix package type validation error in harvesting process
Fix ConvertFrom-ClearlyDefinedCoordinates to handle API object coordinates
Feb 25, 2026
TravisEz13
reviewed
Feb 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR primarily fixes ConvertFrom-ClearlyDefinedCoordinates to correctly handle coordinates values returned as deserialized API objects (in addition to the existing string form), preventing downstream failures when harvesting ClearlyDefined data. It also includes several dependency/version updates across manifests and projects.
Changes:
- Update
ConvertFrom-ClearlyDefinedCoordinatesto accept either a coordinate string or an APIPSCustomObjectand normalize both into the same output shape. - Update cgmanifest registrations and various project dependencies (e.g., Markdig.Signed, System.Data.SqlClient, Perfolizer, Microsoft.NET.Test.Sdk).
- Bump
.NET SDK imageversion inDotnetRuntimeMetadata.json.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/clearlyDefined/src/ClearlyDefined/ClearlyDefined.psm1 | Accept object-form coordinates from the ClearlyDefined API and map properties directly. |
| tools/cgmanifest/main/cgmanifest.json | Update component versions and reposition $schema. |
| test/xUnit/xUnit.tests.csproj | Update Microsoft.NET.Test.Sdk package version. |
| test/tools/TestService/TestService.csproj | Update System.Data.SqlClient dependency version. |
| test/perf/dotnet-tools/ResultsComparer/ResultsComparer.csproj | Update Perfolizer dependency version. |
| src/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj | Update System.Data.SqlClient dependency version. |
| src/Microsoft.PowerShell.Commands.Utility/Microsoft.PowerShell.Commands.Utility.csproj | Update Markdig.Signed dependency version. |
| DotnetRuntimeMetadata.json | Update sdkImageVersion. |
SeeminglyScience
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConvertFrom-ClearlyDefinedCoordinatesonly accepted[string]input, butGet-ClearlyDefinedDatareturns the raw ClearlyDefined API response whosecoordinatesproperty is a deserializedPSCustomObject— not a string. PowerShell coerced the object to"@{type=nuget; provider=nuget; name=Markdig.Signed; revision=1.0.0}", which split by/produced no useful parts, causingStart-ClearlyDefinedHarvestto fail[ValidateSet('nuget')]onPackageType.Changes
tools/clearlyDefined/src/ClearlyDefined/ClearlyDefined.psm1: Removed[string]type constraint fromConvertFrom-ClearlyDefinedCoordinatesand added branch logic to handle both input forms:"nuget/nuget/-/Name/Version"): splits by/as beforetype,provider,namespace,name,revisionproperties directly✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.